Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create projects for KMS resources #1032

Conversation

daniel-cit
Copy link
Contributor

This PR creates projects for Cloud Key Management Service (KMS) resources at org level and at environment level independently of the secrets projects for better separation of concerns related to the Secret Manager.

@daniel-cit daniel-cit requested review from rjerrems, gtsorbo and a team as code owners November 21, 2023 20:23
Copy link

@lanre-OG lanre-OG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

/gcbrun

3 similar comments
@gtsorbo
Copy link
Contributor

gtsorbo commented Dec 18, 2023

/gcbrun

@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

/gcbrun

1 similar comment
@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

@gtsorbo @apeabody @bharathkkb Approved build is finally green 🎉

@apeabody apeabody merged commit f16e805 into terraform-google-modules:master Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants