Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing terraform cloud deploy with agents #1034

Conversation

romanini-ciandt
Copy link
Member

@romanini-ciandt romanini-ciandt commented Nov 22, 2023

The goal of this PR is to introduce Terraform Cloud (TFC) deploy method into foundation structure.
The scope of this PR is from 0-bootstrap step until 4-projects, with Terraform Cloud Agents support.

5-app-infra support will be included in the next PR (it is still WIP)

@romanini-ciandt romanini-ciandt requested review from rjerrems, gtsorbo and a team as code owners November 22, 2023 14:45
@romanini-ciandt romanini-ciandt marked this pull request as draft November 22, 2023 14:45
Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtsorbo
Copy link
Contributor

gtsorbo commented Dec 15, 2023

Looks like there are some conflicts with the main branch - I think the fork needs to re-sync with the repo to incorporate recent changes (i.e. VPC flow logs variable)

@daniel-cit
Copy link
Contributor

Looks like there are some conflicts with the main branch - I think the fork needs to re-sync with the repo to incorporate recent changes (i.e. VPC flow logs variable)

Thanks @gtsorbo I will fix the conflicts

@daniel-cit
Copy link
Contributor

Looks like there are some conflicts with the main branch - I think the fork needs to re-sync with the repo to incorporate recent changes (i.e. VPC flow logs variable)

Thanks @gtsorbo I will fix the conflicts

conflicts fixed

@gtsorbo gtsorbo merged commit 2c96a2f into terraform-google-modules:master Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants