Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to proxy-only subnetworks and new IP CIDR allocation #1040

Merged
merged 52 commits into from
Dec 21, 2023

Conversation

Samir-Cit
Copy link
Contributor

@Samir-Cit Samir-Cit commented Nov 29, 2023

Hello folks.

This PR will:

  • Add support to proxy-only subnetworks in all environments and also to hub-and-spoke.
  • Allocate new IP to the already existing subnetworks.
  • Allocate new IP CIDR ranges to the already existing subnetworks.
Issue1: The IP for PSC endpoints used in code conflict with the primary subnet ranges, the IP used by PSC should be unallocated for additional regions. We need to identify an IP that doesn't break the logic of IP allocation in the document.

Issue2: The doc shows the IP Ranges with CIDR /18 and on the code is using /21, these should be consistent

Issue3: PSA requires a /16 range for each vpc, this is unreasonable. Recommendation is /20.

Issue4: PSC, PSA also need to be provisioned for common network in hub-and-spoke

Issue5: No proxy-only subnets for load balancers are provisioned. Recommended /23 size, In all subnets (including common)

@Samir-Cit Samir-Cit marked this pull request as ready for review December 6, 2023 19:17
Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtsorbo
Copy link
Contributor

gtsorbo commented Dec 21, 2023

/gcbrun

@daniel-cit
Copy link
Contributor

@gtsorbo @apeabody @bharathkkb @rjerrems
Approve PR is green 🎉

@apeabody apeabody merged commit 79b217e into terraform-google-modules:master Dec 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants