Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change old firewall to new network-firewall #1041

Merged
merged 57 commits into from
Dec 27, 2023
Merged

feat: Change old firewall to new network-firewall #1041

merged 57 commits into from
Dec 27, 2023
+604 −712

Conversation

Samir-Cit
Copy link
Contributor

@Samir-Cit Samir-Cit commented Nov 29, 2023 •
edited
Loading

Hello folks.

This PR is to change all compute firewall resources (google_compute_firewall) to the new network firewall resource (google_compute_network_firewall_policy_rule) using the module (terraform-google-modules/network/google//modules/network-firewall-policy)

This network firewall policy module will:

  • Create a Firewall Policy
  • Create a Firewall Policy Association between the Firewall Policy and the VPC network
  • Create the Firewall Policy Rules linked to the Firewall Policy.

@Samir-Cit
Base shared VPC
728955a
@Samir-Cit
Base shared VPC
c794a06
@Samir-Cit
Restricted shared VPC
ffd2c32
@Samir-Cit
Base shared VPC - Hub and spoke
94916b3
@Samir-Cit
Base restricted VPC - Hub and spoke
4b01e97
@Samir-Cit
Small fixes
209bc56
@Samir-Cit
Jenkins Agent
927373b
@Samir-Cit
Service Control depends on
2ffaa77
@Samir-Cit
Trasitivity
5dedb6a
@Samir-Cit
Trasitivity
5411c9f
@Samir-Cit
Example peering project
f3be419
@Samir-Cit
Firewall descriptions.
0ed8b6b
@Samir-Cit
Lint
8f2d4c8
@Samir-Cit
Merge remote-tracking branch 'origin/master' into feat/new-firewall
9b4f5f3
@Samir-Cit
Refactoring ingress and egress internal ranges
5bd9343
@Samir-Cit
Remove unnused tags
50b3744
@Samir-Cit
Remove unnused tags
26f56e3
@Samir-Cit
Lint
822fe86
@Samir-Cit
Jenkins firewall
f64a32f
@Samir-Cit
Change google apis priority
cde1b2d
@Samir-Cit
Change comments with mandatory text
5354282
@Samir-Cit
Refactoring trasitivity module
6df1d83
@Samir-Cit
Changes on internal traffic firewall and init hub-and-spoke firewall
7169733
@Samir-Cit
Lint
9e7215a
@Samir-Cit
Jenkins VM with resource manager tag
6e98cbf
@Samir-Cit
Hub and Spoke - Transitivity
3639016
@Samir-Cit
Merge remote-tracking branch 'origin/master' into feat/new-firewall
0657dc9
@Samir-Cit
Fix subnet creation on entire foundation
54e2337
@Samir-Cit
Fix how to create firewall rules
a08208b
@Samir-Cit
Remove new firewall from trasitivity
a0146fa
Samir-Cit and others added 14 commits November 30, 2023 02:45
lanre-OG
lanre-OG approved these changes Dec 13, 2023
View reviewed changes
Copy link

@lanre-OG lanre-OG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasonbisson
jasonbisson reviewed Dec 15, 2023
View reviewed changes
Copy link

@jasonbisson jasonbisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but integration tests are still failing.

@daniel-cit
Copy link
Contributor

/gcbrun

@rjerrems
Copy link
Collaborator

/gcbrun

gtsorbo
gtsorbo approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-cit
Copy link
Contributor

@gtsorbo @apeabody @bharathkkb @rjerrems
Approve PR is green 🎉

@apeabody apeabody enabled auto-merge (squash) December 26, 2023 19:20
@apeabody apeabody merged commit f2469c1 into terraform-google-modules:master Dec 27, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbisson jasonbisson jasonbisson left review comments

@lanre-OG lanre-OG lanre-OG approved these changes

@rjerrems rjerrems rjerrems approved these changes

@gtsorbo gtsorbo gtsorbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Samir-Cit @daniel-cit @rjerrems @gtsorbo @lanre-OG @jasonbisson @apeabody