Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump terraform base version from 1.3.0 to 1.3.10 #1253

Merged
merged 4 commits into from
May 29, 2024

Conversation

caetano-colin
Copy link
Member

Because of the issue described in this link:
hashicorp/terraform#34014

Some users may experience this error:

unsupported checkable object kind "var"

This can easily be fixed by upgrading the version to 1.3.10 when using terraform 1.3 series

@caetano-colin caetano-colin changed the title DRAFT: bump terraform base version from 1.3.0 to 1.3.10 fix: bump terraform base version from 1.3.0 to 1.3.10 May 24, 2024
@caetano-colin caetano-colin marked this pull request as ready for review May 24, 2024 19:12
@caetano-colin caetano-colin requested review from rjerrems, gtsorbo, eeaton and a team as code owners May 24, 2024 19:12
@bdashrad
Copy link
Contributor

i've been running this project on 1.7.4 without issues, we could probably upgrade even further.

@daniel-cit
Copy link
Contributor

/gcbrun

Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Note: I have been running a full LZ deploy using terraform 1.3.10 override for the last couple deploys - all is good - as expected
GoogleCloudPlatform/pbmm-on-gcp-onboarding#360

The 0-bootstrap step should be run with 1.3.10 and not 1.5+ or a statefile sync issue will occur in 1-org when we kick in the CB trigger that runs the 1.3.10 container

@fmichaelobrien
Copy link
Contributor

reference: #1151

@eeaton eeaton requested a review from sleighton2022 as a code owner May 29, 2024 14:00
@eeaton
Copy link
Collaborator

eeaton commented May 29, 2024

/gcbrun

@eeaton eeaton merged commit a97d2b4 into terraform-google-modules:master May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants