Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump terraform version from 1.3.10 to 1.5.7 #1268

Merged

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Jun 13, 2024

Bump Terrafom version from 1.3.10 to 1.5.7

Version 1.5.7 is the last version before the License change from Mozilla Public License, version 2.0 to Business Source License 1.1

@eeaton eeaton changed the title fix: bump terraform base version from 1.3.10 to 1.5.7 fix: bump terraform base version from 1.3.10 to 1.5.7 Jun 17, 2024
@eeaton eeaton changed the title fix: bump terraform base version from 1.3.10 to 1.5.7 fix: bump terraform version from 1.3.10 to 1.5.7 Jun 17, 2024
@eeaton
Copy link
Collaborator

eeaton commented Jun 17, 2024

Looks like all checks have passed except conventonalcommits.org has stalled, i couldn't manually retrigger it but found that editing the PR title could retrigger it. All checks are now green.

Non-blocking comment: Issue #1265 was asking for a version with security support, which only comes with 1.7 or 1.8, so I'm not sure that these changes fully address the feature request. I don't fully understand the implications of the license change that occurred after 1.5.7, but assuming we are unwilling to use versions with the new license then this fix an explanation in text is sufficient.

@eeaton eeaton merged commit 77827b2 into terraform-google-modules:master Jun 17, 2024
7 checks passed
@ofek
Copy link

ofek commented Jan 21, 2025

Are there plans to support newer versions of Terraform? We are concerned that using these blueprints presents a risk when we must use newer versions for bug fixes.

@apeabody
Copy link
Contributor

Are there plans to support newer versions of Terraform? We are concerned that using these blueprints presents a risk when we must use newer versions for bug fixes.

Hi @ofek - You can use a newer version of Terraform (just needs to be consistent), the documentation on how to set can be found here: https://github.com/terraform-google-modules/terraform-example-foundation/blob/main/0-bootstrap/README-GitHub.md#requirements

@ofek
Copy link

ofek commented Jan 21, 2025

Hey there Andrew, thanks! Yes I saw that but was curious if newer versions are actually tested here. Also I'm not completely familiar with the licensing implications; is the decision that documentation will always reference 1.5.7?

@apeabody
Copy link
Contributor

Hey there Andrew, thanks! Yes I saw that but was curious if newer versions are actually tested here. Also I'm not completely familiar with the licensing implications; is the decision that documentation will always reference 1.5.7?

I'll defer to the repo maintainers on the roadmap question, however given the Terraform version compatibility I would not expect issues using more recent v1 Terraform releases. As an example I believe this repo's linter is currently using Terraform v1.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants