Chore(docs): Add guidance about deprecated deployment methods and intended support #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeaton
requested review from
rjerrems,
gtsorbo,
sleighton2022 and
a team
as code owners
eeaton
changed the title
eeaton
changed the title
|
Will add a doc fix for #1239 as well because it touches on similar issues |
…/eeaton/terraform-example-foundation into readme-update-deployment-options
daniel-cit
approved these changes
Jun 24, 2024
accept suggested changes Co-authored-by: Daniel Andrade <[email protected]>
apeabody
approved these changes
Jun 24, 2024
| Though this blueprint can help accelerate your foundation design and build, we assume that you have the engineering skills and teams to deploy and customize your own foundation based on your own requirements. | ||
|
|
||
| We will support: | ||
| - Code is semantically valid, pinned to known good versions, and passes terraform validate and lint checks |
There was a problem hiding this comment.
nit: proper noun?
Suggested change
| - Code is semantically valid, pinned to known good versions, and passes terraform validate and lint checks | |
| - Code is semantically valid, pinned to known good versions, and passes Terraform validate and lint checks |
| Though this blueprint can help accelerate your foundation design and build, we assume that you have the engineering skills and teams to deploy and customize your own foundation based on your own requirements. | ||
|
|
||
| We will support: | ||
| - Code is semantically valid, pinned to known good versions, and passes terraform validate and lint checks |
There was a problem hiding this comment.
Suggested change
| - Code is semantically valid, pinned to known good versions, and passes terraform validate and lint checks | |
| - Code is semantically valid, pinned to known good versions, and passes Terraform validate and lint checks |
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings about jenkins, CSR for new organizations.
I raised this issue in #1275 1275. Quick fix until we can properly address this in #1249