Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update tf-wrapper.sh script to deal with generic folder hierarchy #992

Merged
merged 7 commits into from
Nov 20, 2023
Merged

feat: update tf-wrapper.sh script to deal with generic folder hierarchy #992

merged 7 commits into from
Nov 20, 2023

Conversation

daniel-cit
Copy link
Contributor

This PR updates the tf-wrapper.sh script to deal with generic source code folder hierarchy

depends on #991

@daniel-cit daniel-cit requested review from rjerrems, gtsorbo and a team as code owners August 29, 2023 16:45
amandakarina
amandakarina reviewed Oct 11, 2023
View reviewed changes
build/tf-wrapper.sh Outdated Show resolved Hide resolved
docs/change_resource_hierarchy.md Outdated Show resolved Hide resolved
jasonbisson
jasonbisson reviewed Nov 13, 2023
View reviewed changes
Copy link

@jasonbisson jasonbisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments about the mindepth and maxdepth variables. Other than that it LGTM

build/tf-wrapper.sh Show resolved Hide resolved
build/tf-wrapper.sh Show resolved Hide resolved
jasonbisson
jasonbisson approved these changes Nov 15, 2023
View reviewed changes
Copy link

@jasonbisson jasonbisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit 4d7e822 into terraform-google-modules:master Nov 20, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandakarina amandakarina amandakarina left review comments

@jasonbisson jasonbisson jasonbisson approved these changes

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-cit @bharathkkb @jasonbisson @amandakarina