Skip to content

Commit

Permalink
feat: Fix failing tests in master (#53)
Browse files Browse the repository at this point in the history
* Bumped devtools container, provider version, project factory version to fix failing tests in master
  • Loading branch information
Ryan Canty authored Sep 22, 2020
1 parent 6193ee2 commit 79f0249
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 53 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,3 @@ crash.log
**/*.tfvars

credentials.json
test/source.sh
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Make will use bash instead of sh
SHELL := /usr/bin/env bash

DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.6.1
DOCKER_TAG_VERSION_DEVELOPER_TOOLS := 0.12.0
DOCKER_IMAGE_DEVELOPER_TOOLS := cft/developer-tools
REGISTRY_URL := gcr.io/cloud-foundation-cicd

Expand Down
2 changes: 1 addition & 1 deletion build/int.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ tags:
- 'integration'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '0.6.1'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '0.12.0'
2 changes: 1 addition & 1 deletion build/lint.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ tags:
- 'lint'
substitutions:
_DOCKER_IMAGE_DEVELOPER_TOOLS: 'cft/developer-tools'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '0.6.1'
_DOCKER_TAG_VERSION_DEVELOPER_TOOLS: '0.12.0'
2 changes: 1 addition & 1 deletion examples/bastion_group/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ variable "target_size" {
}
variable "project" {
description = "Project ID where the bastion will run"
type = "string"
type = string
}

variable "region" {
Expand Down
2 changes: 1 addition & 1 deletion examples/simple_example/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ variable "members" {

variable "project" {
description = "Project ID where the bastion will run"
type = "string"
type = string
}

variable "region" {
Expand Down
5 changes: 1 addition & 4 deletions modules/bastion-group/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,5 @@
* limitations under the License.
*/
terraform {
required_version = "~> 0.12"
required_providers {
google = "~> 3.15"
}
required_version = ">=0.12.6, <0.14"
}
5 changes: 1 addition & 4 deletions modules/iap-tunneling/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,5 @@
* limitations under the License.
*/
terraform {
required_version = "~> 0.12"
required_providers {
google = "~> 3.15"
}
required_version = ">=0.12.6, <0.14"
}
2 changes: 1 addition & 1 deletion test/setup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

module "project_ci" {
source = "terraform-google-modules/project-factory/google"
version = "~> 3.0"
version = "~> 9.0"

name = "ci-bastion-module"
random_project_id = true
Expand Down
23 changes: 0 additions & 23 deletions test/setup/make_source.sh

This file was deleted.

7 changes: 5 additions & 2 deletions test/setup/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ output "project_id" {
value = module.project_ci.project_id
}

output "sa_email" {
value = google_service_account.ci_account.email
output "service_account" {
value = {
email = google_service_account.ci_account.email
scopes = ["cloud-platform"]
}
}
10 changes: 1 addition & 9 deletions test/setup/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,5 @@
*/

terraform {
required_version = ">= 0.12"
}

provider "google" {
version = "~> 2.13.0"
}

provider "google-beta" {
version = "~> 2.13.0"
required_version = ">=0.12.6, <0.14"
}
5 changes: 1 addition & 4 deletions versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,5 @@
* limitations under the License.
*/
terraform {
required_version = "~> 0.12"
required_providers {
google = "~> 3.15"
}
required_version = ">=0.12.6, <0.14"
}

0 comments on commit 79f0249

Please sign in to comment.