Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Debian Image to 12 #179

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Fix: Update Debian Image to 12 #179

merged 5 commits into from
Apr 5, 2024

Conversation

RoseSecurity
Copy link
Contributor

What and Why

  • Update default machine_type to debian-12
  • Debian 12.0 was initially released on June 10th, 2023

Signed-off-by: Michael Rosenfeld <[email protected]>
@RoseSecurity RoseSecurity requested a review from a team as a code owner January 25, 2024 21:48
Copy link

google-cla bot commented Jan 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@RoseSecurity
Copy link
Contributor Author

@Djabx Any thoughts on this?

@Djabx
Copy link
Contributor

Djabx commented Apr 4, 2024

@RoseSecurity Hi,
No issue for me: I'm setting the variable on my side.

But I'm just a contributor, not a maintainer :P

@apeabody
Copy link
Contributor

apeabody commented Apr 5, 2024

Thanks for the contribution @RoseSecurity!

It looks like one of the commits used an email address not covered by the CLA.

@RoseSecurity
Copy link
Contributor Author

RoseSecurity commented Apr 5, 2024

Thanks for the contribution @RoseSecurity!

It looks like one of the commits used an email address not covered by the CLA.

No worries! Just signed the CLA with that email address as well. @apeabody

@apeabody
Copy link
Contributor

apeabody commented Apr 5, 2024

Thanks for the contribution @RoseSecurity!
It looks like one of the commits used an email address not covered by the CLA.

No worries! Just signed the CLA with that email address as well. @apeabody

Thanks! - That check is now green.

@apeabody
Copy link
Contributor

apeabody commented Apr 5, 2024

/gcbrun

@apeabody apeabody changed the title Update Debian Image to 12 Fix: Update Debian Image to 12 Apr 5, 2024
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @RoseSecurity!

@apeabody
Copy link
Contributor

apeabody commented Apr 5, 2024

/gcbrun

@apeabody apeabody enabled auto-merge (squash) April 5, 2024 20:15
@apeabody apeabody merged commit ae88275 into terraform-google-modules:master Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants