remove extra code

terraform-google-modules · Oct 31, 2024 · 3c97c4b · 3c97c4b
1 parent 5f382d6
commit 3c97c4b
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 18 deletions.
diff --git a/test/fixtures/tf_cloudbuild_builder_simple_github/outputs.tf b/test/fixtures/tf_cloudbuild_builder_simple_github/outputs.tf
@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 output "artifact_repo" {
   description = "GAR Repo created to store TF Cloud Builder images"
   value       = module.example.artifact_repo

diff --git a/test/fixtures/tf_cloudbuild_builder_simple_gitlab/outputs.tf b/test/fixtures/tf_cloudbuild_builder_simple_gitlab/outputs.tf
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-
 output "artifact_repo" {
   description = "GAR Repo created to store TF Cloud Builder images"
   value       = module.example.artifact_repo

diff --git a/test/integration/im_cloudbuild_workspace_github/im_cloudbuild_workspace_github_test.go b/test/integration/im_cloudbuild_workspace_github/im_cloudbuild_workspace_github_test.go
@@ -255,7 +255,6 @@ func TestIMCloudBuildWorkspaceGitHub(t *testing.T) {
 					}
 					if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 						t.Logf("%v", build[0])
-						// utils.PrintLog(t, "TestIMCloudBuildWorkspaceGitHub", projectID)
 						t.Fatalf("workflow %s failed with failureInfo %s", build[0].Get("id"), build[0].Get("failureInfo"))
 					}
 					return true, nil

diff --git a/test/integration/im_cloudbuild_workspace_gitlab/im_cloudbuild_workspace_gitlab_test.go b/test/integration/im_cloudbuild_workspace_gitlab/im_cloudbuild_workspace_gitlab_test.go
@@ -272,7 +272,6 @@ func TestIMCloudBuildWorkspaceGitLab(t *testing.T) {
 					}
 					if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 						t.Logf("%v", build[0])
-						// utils.PrintLog(t, "TestIMCloudBuildWorkspaceGitLab", projectID)
 						t.Fatalf("workflow %s failed with status %s", build[0].Get("id"), latestWorkflowRunStatus)
 						return false, nil
 					}

diff --git a/...tegration/tf_cloudbuild_builder_simple_github/tf_cloudbuild_builder_simple_github_test.go b/...tegration/tf_cloudbuild_builder_simple_github/tf_cloudbuild_builder_simple_github_test.go
@@ -193,7 +193,6 @@ func TestTFCloudBuildBuilderGitHub(t *testing.T) {
 				}
 				if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 					t.Logf("%v", build[0])
-					// utils.PrintLog(t, "TestTFCloudBuildBuilderGitHub", projectID)
 					t.Fatalf("workflow %s failed with failureInfo %s", build[0].Get("id"), build[0].Get("failureInfo"))
 				}
 				return true, nil

diff --git a/...tegration/tf_cloudbuild_builder_simple_gitlab/tf_cloudbuild_builder_simple_gitlab_test.go b/...tegration/tf_cloudbuild_builder_simple_gitlab/tf_cloudbuild_builder_simple_gitlab_test.go
@@ -202,7 +202,6 @@ func TestTFCloudBuildBuilderGitLab(t *testing.T) {
 				}
 				if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 					t.Logf("%v", build[0])
-					// utils.PrintLog(t, "TestTFCloudBuildBuilderGitLab", projectID)
 					t.Fatalf("workflow %s failed with failureInfo %s", build[0].Get("id"), build[0].Get("failureInfo"))
 				}
 				return true, nil

diff --git a/...ation/tf_cloudbuild_workspace_simple_github/tf_cloudbuild_workspace_simple_github_test.go b/...ation/tf_cloudbuild_workspace_simple_github/tf_cloudbuild_workspace_simple_github_test.go
@@ -188,7 +188,6 @@ func TestCloudBuildWorkspaceSimpleGitHub(t *testing.T) {
 					}
 					if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 						t.Logf("%v", build[0])
-						// utils.PrintLog(t, "TestCloudBuildWorkspaceSimpleGitHub", projectID)
 						t.Fatalf("workflow %s failed with failureInfo %s", build[0].Get("id"), build[0].Get("failureInfo"))
 					}
 					return true, nil

diff --git a/...ation/tf_cloudbuild_workspace_simple_gitlab/tf_cloudbuild_workspace_simple_gitlab_test.go b/...ation/tf_cloudbuild_workspace_simple_gitlab/tf_cloudbuild_workspace_simple_gitlab_test.go
@@ -207,7 +207,6 @@ func TestCloudBuildWorkspaceSimpleGitLab(t *testing.T) {
 					}
 					if latestWorkflowRunStatus == "TIMEOUT" || latestWorkflowRunStatus == "FAILURE" {
 						t.Logf("%v", build[0])
-						// utils.PrintLog(t, "TestCloudBuildWorkspaceSimpleGitLab", projectID)
 						t.Fatalf("workflow %s failed with status %s", build[0].Get("id"), latestWorkflowRunStatus)
 						return false, nil
 					}

diff --git a/test/integration/utils/utils.go b/test/integration/utils/utils.go
@@ -15,12 +15,10 @@
 package utils
 
 import (
-	"fmt"
 	"os"
 	"strings"
 	"testing"
 
-	"github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test/pkg/gcloud"
 	"github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test/pkg/tft"
 )
 
@@ -46,12 +44,3 @@ func GetFileContents(t *testing.T, path string) []byte {
 func LastElement(str, sep string) string {
 	return strings.Split(str, sep)[len(strings.Split(str, sep))-1]
 }
-
-// PrintLogErrors print the logs of severity ERROR to the test output.
-func PrintLog(t *testing.T, tag, projectID string) {
-	logsCmd := fmt.Sprintf("logging read --project=%s --order=asc", projectID)
-	logs := gcloud.Runf(t, logsCmd).Array()
-	for _, log := range logs {
-		t.Logf("%s build-log: %s", tag, log.Get("textPayload").String())
-	}
-}