Skip to content

Commit

Permalink
code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-cit committed Nov 1, 2024
1 parent e420434 commit b0d932f
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/fixtures/cloudbuild_repo_connection_github/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ variable "project_id" {
variable "github_pat" {
description = "The personal access token for authenticating with GitHub."
type = string
sensitive = true
}

variable "github_app_id" {
description = "The application ID for the Cloudbuild GitHub app."
type = string
sensitive = true
}

variable "repository_url" {
Expand Down
2 changes: 2 additions & 0 deletions test/fixtures/cloudbuild_repo_connection_gitlab/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ variable "repository_name" {
variable "gitlab_authorizer_credential" {
description = "Credential for GitLab authorizer"
type = string
sensitive = true
}

variable "gitlab_read_authorizer_credential" {
description = "Credential for GitLab read authorizer"
type = string
sensitive = true
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ variable "project_id" {
variable "github_pat" {
description = "The personal access token for authenticating with GitHub."
type = string
sensitive = true
}

variable "github_app_id" {
description = "The application ID for the Cloudbuild GitHub app."
type = string
sensitive = true
}

variable "repository_uri" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ variable "repository_uri" {
variable "gitlab_authorizer_credential" {
description = "Credential for GitLab authorizer"
type = string
sensitive = true
}

variable "gitlab_read_authorizer_credential" {
description = "Credential for GitLab read authorizer"
type = string
sensitive = true
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@ variable "project_id" {
variable "github_pat" {
description = "The personal access token for authenticating with GitHub."
type = string
sensitive = true
}

variable "github_app_id" {
description = "The application ID for the Cloudbuild GitHub app."
type = string
sensitive = true
}

variable "repository_uri" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,11 @@ variable "repository_uri" {
variable "gitlab_authorizer_credential" {
description = "Credential for GitLab authorizer"
type = string
sensitive = true
}

variable "gitlab_read_authorizer_credential" {
description = "Credential for GitLab read authorizer"
type = string
sensitive = true
}

0 comments on commit b0d932f

Please sign in to comment.