feat(modules)!: enable cloudbuildv2 repository support on tf_cloudbuild_builder and tf_cloudbuild_workspace #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
apeabody
reviewed
Aug 7, 2024
test/integration/tf_cloudbuild_builder_simple/tf_cloudbuild_builder_simple_test.go
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
@apeabody Could you PTAL again? |
apeabody
reviewed
Aug 9, 2024
|
/gcbrun |
|
/gcbrun |
apeabody
reviewed
Aug 15, 2024
| @@ -70,7 +70,7 @@ variable "gar_repo_name" { | |||
| variable "gar_repo_location" { | |||
| description = "Name of the location for the Google Artifact Repository." | |||
| type = string | |||
| default = "us" | |||
| default = "us-central1" | |||
There was a problem hiding this comment.
I think it's probably better to remove the default entirely, rather than change the default value. That way during an module upgrade an error is surfaced if using the default, rather than the value unexpectedly changing.
apeabody
reviewed
Aug 15, 2024
| @@ -94,12 +94,19 @@ variable "trigger_name" { | |||
| variable "trigger_location" { | |||
| description = "Location of the Cloud Build trigger building the Terraform builder. If using private pools should be the same location as the pool." | |||
| type = string | |||
| default = "global" | |||
| default = "us-central1" | |||
apeabody
reviewed
Aug 15, 2024
| @@ -28,7 +28,7 @@ variable "location" { | |||
| variable "trigger_location" { | |||
| description = "Location of for Cloud Build triggers created in the workspace. If using private pools should be the same location as the pool." | |||
| type = string | |||
| default = "global" | |||
| default = "us-central1" | |||
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf_cloudbuild_builder module:
source_to_buildargument for cloudbuildv2 repository, in this case the user shall not specifydockerfile_repo_uri(it is used for CSR) and specify the variabledockerfile_repo_idwith the cloudbuildv2 id.tf_cloudbuild_workspace module:
tf_repo_typecalledCLOUDBUILD_V2_REPOSITORYthat shall be used when specifying a cloudbuildv2 repository oncloudbuildv2_repository_idvariable