New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module): add cloudbuild connection module #312

Merged

apeabody merged 25 commits into terraform-google-modules:master from caetano-colin:feat/connection-module

Aug 22, 2024

Member

caetano-colin commented Aug 16, 2024 •

edited

Loading

This PR will add the module cloudbuild_repo_connection.

This module is designed to create and manage secret versions, as well as configure the necessary permissions for cloud build service agent when utilizing Cloud Build repositories (2nd generation).

Additionally, it will establish the corresponding Cloud Build repositories based on the cloudbuild_repos variable, where users can specify the repository names and URLs from their version control systems.

Users will provide the required secrets through the credential_config variable, indicating their chosen Git provider. Currently, the module supports both GitHub and GitLab.

caetano-colin added 2 commits

August 16, 2024 08:27


          first commit

a26009d


          adjust environment from local -> cloud

af9a888

caetano-colin changed the title ~~DRAFT: add connection module~~ DRAFT: feat(module): add cloudbuild connection module

caetano-colin added 5 commits

August 16, 2024 08:42


          terraform fmt

99e63a6


          add newlines to eof

e033ba3


          add headers

fa0db9d


          update docs and add versions.tf

545047c


          add version constraints

8be209c

Member Author

caetano-colin commented Aug 16, 2024

/gcbrun

1 similar comment

Contributor

daniel-cit commented Aug 16, 2024

/gcbrun


          add tests to cloudbuild.yaml

7b17fe1

Contributor

daniel-cit commented Aug 16, 2024

/gcbrun


          add example readmes

2df1ddb

Contributor

apeabody commented Aug 16, 2024

/gcbrun


          remove hardcoded values

d24682a

Contributor

daniel-cit commented Aug 17, 2024

/gcbrun

daniel-cit reviewed

View reviewed changes

examples/cloudbuild_repo_connection_github/variables.tf Outdated Show resolved Hide resolved

daniel-cit reviewed

View reviewed changes

examples/cloudbuild_repo_connection_github/variables.tf Outdated Show resolved Hide resolved

daniel-cit reviewed

View reviewed changes

modules/cloudbuild_repo_connection/variables.tf Outdated Show resolved Hide resolved

daniel-cit reviewed

View reviewed changes

modules/cloudbuild_repo_connection/variables.tf Outdated Show resolved Hide resolved

daniel-cit reviewed

View reviewed changes

modules/cloudbuild_repo_connection/variables.tf Outdated Show resolved Hide resolved


          use the repo name in the verification of the connections repositories

ed0cd74

daniel-cit reviewed

View reviewed changes

test/integration/cloudbuild_repo_connection_github/cloudbuild_repo_connection_github_test.go Outdated Show resolved Hide resolved

Contributor

daniel-cit commented Aug 17, 2024

/gcbrun


          update teste repo names for connection test

6e8e722

Contributor

daniel-cit commented Aug 18, 2024

/gcbrun

caetano-colin added 3 commits

August 19, 2024 10:58


          implement code review changes

fc8e5d3


          remove whitespace

d0e6b86


          idented heredoc

Contributor

daniel-cit commented Aug 19, 2024

/gcbrun

apeabody reviewed

View reviewed changes

modules/cloudbuild_repo_connection/versions.tf Outdated Show resolved Hide resolved

apeabody reviewed

View reviewed changes

modules/cloudbuild_repo_connection/versions.tf Outdated Show resolved Hide resolved

apeabody reviewed

View reviewed changes

modules/cloudbuild_repo_connection/versions.tf Outdated Show resolved Hide resolved

caetano-colin and others added 5 commits

August 19, 2024 15:48


          add regex text

1ba0a76


          resolve conflicts

939e20f


          remove 'test'

30d455c


          Apply suggestions from code review

183f902

Co-authored-by: Andrew Peabody <[email protected]>


          generate docs

0a508ab

Contributor

daniel-cit commented Aug 19, 2024

/gcbrun


          remove location as var

340c604

Contributor

daniel-cit commented Aug 19, 2024

/gcbrun

caetano-colin changed the title ~~DRAFT: feat(module): add cloudbuild connection module~~ feat(module): add cloudbuild connection module

caetano-colin marked this pull request as ready for review

August 20, 2024 14:14

caetano-colin requested a review from a team as a code owner

August 20, 2024 14:14

apeabody requested changes

View reviewed changes

Contributor

apeabody left a comment

Thanks @caetano-colin! A few minor things I noted during the final review.

examples/cloudbuild_repo_connection_gitlab/main.tf Show resolved Hide resolved

test/integration/cloudbuild_repo_connection_gitlab/cloudbuild_repo_connection_gitlab_test.go Outdated Show resolved Hide resolved

test/integration/cloudbuild_repo_connection_github/cloudbuild_repo_connection_github_test.go Outdated Show resolved Hide resolved

apeabody requested a review from gtsorbo

August 20, 2024 20:27


          change module source on example, use fmt.Sprintf on location assertion

ed8c7c7

Member Author

caetano-colin commented Aug 21, 2024

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:

version = "~> 9.0"

I'm assuming that would be the module version, If that is not correct please let me know.

Contributor

apeabody commented Aug 21, 2024

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:
version = "~> 9.0"
I'm assuming that would be the module version, If that is not correct please let me know.

Yeah, that should be fine for now. Thanks!

Contributor

apeabody commented Aug 21, 2024

/gcbrun

Contributor

apeabody commented Aug 21, 2024

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

apeabody approved these changes

View reviewed changes

Contributor

apeabody commented Aug 21, 2024

@gtsorbo do you want to review before merging?


          increase build timeout in 10minutes

1ff590e

Member Author

caetano-colin commented Aug 22, 2024

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

Created a commit that increases the timeout in 10minutes

Contributor

daniel-cit commented Aug 22, 2024

/gcbrun

daniel-cit self-requested a review

August 22, 2024 18:02

daniel-cit approved these changes

View reviewed changes

Contributor

daniel-cit left a comment

LGTM

apeabody merged commit f79bbc5 into terraform-google-modules:master

4 checks passed

release-please bot mentioned this pull request

chore(master): release 9.0.0 #306

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet