Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom host in gitlab #328

Conversation

caetano-colin
Copy link
Member

@caetano-colin caetano-colin commented Nov 22, 2024

This PR allows the user to use gitlab enterprise (specify custom gitlab host and custom CA certificate for connections using service directory)

@caetano-colin caetano-colin changed the title draft: add support for custom host draft: add support for custom host in gitlab Nov 22, 2024
@caetano-colin caetano-colin changed the title draft: add support for custom host in gitlab feat: add support for custom host in gitlab Dec 2, 2024
@caetano-colin caetano-colin marked this pull request as ready for review December 2, 2024 16:48
@caetano-colin caetano-colin requested a review from a team as a code owner December 2, 2024 16:48
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caetano-colin!

One nit and this should be ready to merge.

modules/cloudbuild_repo_connection/variables.tf Outdated Show resolved Hide resolved
@apeabody apeabody merged commit 62eb9ae into terraform-google-modules:master Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants