feat: Add routing policy wrr and geo to google_dns_record_set #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennislapchenko
force-pushed
the
feat/add_routing_policy_wrr_and_geo_to_dns-record-set
branch
from
1097b82 to
3e5619f
Compare
|
@dennislapchenko can you plz generate document |
Done |
|
/gcbrun |
|
/gcbrun |
imrannayer
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set
routing_policywithwrrandgeoblocks.As per resource docs here.
It is not a fully implementation of all fields in
routing_policy, just the basicgeoandwrrusage.It can be iterated upon for a full coverage of
routing_policyoptions.Initially played with condition validation but is not really required as it well done in the resource implementation itself.