feat: bgp block can now be optional
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, bad commit message. It's a feature not a chore. |
imrannayer
changed the title
bgp block can now be optionalbgp block can now be optional
|
@tanguynicolas thx for the PR. can you plz fix lint issues. See contributing guide |
|
/gcbrun |
1 similar comment
|
/gcbrun |
imrannayer
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a customer who has not defined (from console) the
bgpblock. When I use the module, it creates a change. I don't currently have the option of setting the ASN to null to avoid creating the block.The purpose of this PR is to support my use case. To reflect a little more the google_compute_router_nat resource which doesn't require the bgp block.