Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3 #27

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Support Python 3 #27

merged 2 commits into from
Sep 30, 2021

Conversation

yuryu
Copy link
Contributor

@yuryu yuryu commented Sep 30, 2021 •
edited
Loading

Support Python 3 for the Python code in script-utils.sh

This also adds the --format=json option to get_describe_command because the result is passed to get_etag, which expects json.

Fixes #26

Note: The tests will fail until #25 is merged.

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 30, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

morgante
morgante suggested changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will also need to be updated, since they check for specific commands.

@morgante morgante merged commit 04094aa into terraform-google-modules:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3
3 participants
@yuryu @comment-bot-dev @morgante