Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add drain IPs option to NAT resource #135

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: add drain IPs option to NAT resource #135

merged 1 commit into from
Nov 5, 2024

Conversation

adudzic
Copy link
Contributor

@adudzic adudzic commented Nov 5, 2024

  • add attribute drain_nat_ips in the nats section of the module
  • add attribute drain_nat_ipsto the google_compute_router_nat.nats resource

resolves #134

@adudzic adudzic requested review from imrannayer and a team as code owners November 5, 2024 15:42
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit d8ec351 into terraform-google-modules:master Nov 5, 2024
4 checks passed
@imrannayer imrannayer self-assigned this Nov 5, 2024
@release-please release-please bot mentioned this pull request Nov 5, 2024
Merged
@adudzic adudzic deleted the drain-ips branch November 6, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a drain_nat_ips atribute to google_compute_router_nat resource
2 participants
@adudzic @imrannayer