-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix type for NAT subnetwork attributes #85
fix: Fix type for NAT subnetwork attributes #85
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@peikk0 thanks for the PR. few change requested |
71b2fd1
to
ad538c5
Compare
/gcbrun |
@peikk0 can you plz follow contribution guide to fix issues with lint test. Thanks |
ad538c5
to
ea52554
Compare
@imrannayer I've fixed the doc linting issue. I was certain I already did it the time before. 🙈 |
/gcbrun |
@peikk0 thx for fixing the issue. If you are getting error with type Thanks |
any update? we cannot merge the update for the same reason |
e0c3223
to
7a4b996
Compare
@imrannayer I've updated the NAT example, it applies cleanly for me. |
/gcbrun |
1 similar comment
/gcbrun |
lookup()
calls with optional attributesFixes #84