Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding "no_age" param in simple bucket #319

Merged

Conversation

jjnunogarcia
Copy link
Contributor

We cannot configure lifecycle rules and add no_age param because this line is missing.

@jjnunogarcia jjnunogarcia requested a review from a team as a code owner June 2, 2024 15:00
Copy link

google-cla bot commented Jun 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jjnunogarcia jjnunogarcia changed the title Simple Bucker: Adding "no_age" param Simple Bucket: Adding "no_age" param Jun 3, 2024
@jjnunogarcia jjnunogarcia force-pushed the missing-no-age-param branch 2 times, most recently from f8baddf to d7e0fd3 Compare June 6, 2024 10:33
@jjnunogarcia jjnunogarcia force-pushed the missing-no-age-param branch from 11ce527 to ab00652 Compare June 23, 2024 05:51
@jjnunogarcia jjnunogarcia changed the title Simple Bucket: Adding "no_age" param fix: adding "no_age" param in simple bucket Jun 23, 2024
Added the missing `no_age` parameter to the terraform module. This parameter is now parsed and sent to the cloud-storage in GCP, ensuring proper configuration of the storage settings.
@jjnunogarcia jjnunogarcia force-pushed the missing-no-age-param branch from ab00652 to 0af5e25 Compare June 23, 2024 05:54
@apeabody
Copy link
Contributor

apeabody commented Jul 3, 2024

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jjnunogarcia!

Confirmed no_age in TPG v5.22

@apeabody apeabody merged commit 87e66bb into terraform-google-modules:master Jul 3, 2024
4 checks passed
@jjnunogarcia jjnunogarcia deleted the missing-no-age-param branch July 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants