Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TPG >=5.3)!: add new features. update provider requirements #98

Merged
merged 9 commits into from
Nov 16, 2023
Merged

feat(TPG >=5.3)!: add new features. update provider requirements #98

merged 9 commits into from
Nov 16, 2023

Conversation

imrannayer
Copy link
Collaborator

@imrannayer imrannayer commented Nov 15, 2023 •
edited
Loading

fix #96
Add support for following features:

  • cloud_data_lineage_integration
  • resilience_mode
  • existing storage_bucket
  • maintenance_window
  • Snapshot Scheduler
  • triggerer

Min Terraform version required 1.3 for composer V2 sub-module
Min TPG version required 5.3 for composer V2 sub-module
Max TF version 5.x

@imrannayer imrannayer requested a review from a team as a code owner November 15, 2023 03:17
This was referenced Nov 15, 2023
Closed
Closed
g-awmalik
g-awmalik approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also add test assertions for the changes you made to the examples in this or a follow-up PR? Thanks!

@imrannayer
Copy link
Collaborator Author

@g-awmalik Will add a new PR for latest assertions.

@imrannayer imrannayer merged commit ea834f7 into terraform-google-modules:master Nov 16, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Nov 16, 2023
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for google-provider 5.0.0
2 participants
@imrannayer @g-awmalik