Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom tags option to mig-vm-module #177

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

ChaosCypher
Copy link
Contributor

@ChaosCypher ChaosCypher commented Aug 16, 2024

  • Allows additional tags to be added to the mig-vm-module

@ChaosCypher ChaosCypher requested review from gtsorbo and a team as code owners August 16, 2024 20:35
Copy link

google-cla bot commented Aug 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nesbittryan
Copy link

Wow! We need this in our project ASAP 🙏 👍

@ChaosCypher ChaosCypher changed the title Add custom tags option to mig-vm-module feat: Add custom tags option to mig-vm-module Aug 16, 2024
@nesbittryan
Copy link

The new title is so accurate 🥇 I knew this would be a feat

@apeabody
Copy link
Contributor

/gcbrun

@ChaosCypher
Copy link
Contributor Author

@apeabody - I'm unable to see what failed in the terraform-google-github-actions-runners-int-trigger job

@apeabody
Copy link
Contributor

@apeabody - I'm unable to see what failed in the terraform-google-github-actions-runners-int-trigger job

I'm not convinced this is related to your change, I'm going to trigger a fresh run:

TestGhRunnerGkeDindRootless 2024-08-16T21:26:05Z command.go:100: Running command gcloud with args [container clusters get-credentials gh-runner-dind-rootless --location us-east4-a --project ci-terraform-gh-runners-1853 --format json]
TestGhRunnerGkeDindRootless 2024-08-16T21:26:07Z command.go:185: Fetching cluster endpoint and auth data.
TestGhRunnerGkeDindRootless 2024-08-16T21:26:08Z command.go:185: kubeconfig entry generated for gh-runner-dind-rootless.
TestGhRunnerGkeDindRootless 2024-08-16T21:26:08Z command.go:185: []
TestGhRunnerGkeDindRootless 2024-08-16T21:26:08Z logger.go:66: Running command kubectl with args [get pods -n arc-systems -o json]
TestGhRunnerGkeDindRootless 2024-08-16T21:26:08Z logger.go:66: error: error loading config file "/builder/home/.kube/config": yaml: line 25: could not find expected ':'
    gh_runner_gke_dind_rootless_test.go:57: Error getting pods: error while running command: exit status 1; error: error loading config file "/builder/home/.kube/config": yaml: line 25: could not find expected ':'

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ChaosCypher!

@apeabody apeabody merged commit 5e1a3c6 into terraform-google-modules:master Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants