fix: Change default rotation period from 28 hours to 90 days

[kjwinters]

Based on Google public docs (https://cloud.google.com/kms/docs/key-rotation#how_often_to_rotate_keys), changing the default key rotation period from ~28 hours to a suggested 90 days.

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @kjwinters - Will changing the default value force a replace for existing resources using the default? If so, we should probably mark as a breaking change.

[chrisw-tracer]

Thanks for the contribution @kjwinters - Will changing the default value force a replace for existing resources using the default? If so, we should probably mark as a breaking change.

@apeabody I just tested this and it won't replace keys, just update them:

# module.kms.google_kms_crypto_key.key[0] will be updated in-place
  ~ resource "google_kms_crypto_key" "key" {
        id                            = "projects/XXXX/locations/us/keyRings/X-keyring/cryptoKeys/X-kms"
        name                          = "XXXX"
      ~ rotation_period               = "7776000s" -> "777000s"
        # (6 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

[apeabody]

Thanks for the contribution @kjwinters - Will changing the default value force a replace for existing resources using the default? If so, we should probably mark as a breaking change.

@apeabody I just tested this and it won't replace keys, just update them:

# module.kms.google_kms_crypto_key.key[0] will be updated in-place
  ~ resource "google_kms_crypto_key" "key" {
        id                            = "projects/XXXX/locations/us/keyRings/X-keyring/cryptoKeys/X-kms"
        name                          = "XXXX"
      ~ rotation_period               = "7776000s" -> "777000s"
        # (6 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Great - Thanks!

[apeabody]

Thanks for the contribution @kjwinters! - LGTM