refactor: remove unnecessary lookup for safer_cluster nodepool ID (#2160

)
terraform-google-modules · Oct 30, 2024 · 179a8ec · 179a8ec
1 parent c9a373a
commit 179a8ec
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/autogen/main/cluster.tf.tmpl b/autogen/main/cluster.tf.tmpl
@@ -753,7 +753,7 @@ locals {
 resource "random_id" "name" {
   for_each    = merge(local.node_pools, local.windows_node_pools)
   byte_length = 2
-  prefix      = format("%s-", lookup(each.value, "name"))
+  prefix      = "${each.key}-"
   keepers = merge(
     zipmap(
       local.force_node_pool_recreation_resources,

diff --git a/modules/beta-private-cluster-update-variant/cluster.tf b/modules/beta-private-cluster-update-variant/cluster.tf
@@ -647,7 +647,7 @@ locals {
 resource "random_id" "name" {
   for_each    = merge(local.node_pools, local.windows_node_pools)
   byte_length = 2
-  prefix      = format("%s-", lookup(each.value, "name"))
+  prefix      = "${each.key}-"
   keepers = merge(
     zipmap(
       local.force_node_pool_recreation_resources,

diff --git a/modules/beta-public-cluster-update-variant/cluster.tf b/modules/beta-public-cluster-update-variant/cluster.tf
@@ -626,7 +626,7 @@ locals {
 resource "random_id" "name" {
   for_each    = merge(local.node_pools, local.windows_node_pools)
   byte_length = 2
-  prefix      = format("%s-", lookup(each.value, "name"))
+  prefix      = "${each.key}-"
   keepers = merge(
     zipmap(
       local.force_node_pool_recreation_resources,

diff --git a/modules/private-cluster-update-variant/cluster.tf b/modules/private-cluster-update-variant/cluster.tf
@@ -588,7 +588,7 @@ locals {
 resource "random_id" "name" {
   for_each    = merge(local.node_pools, local.windows_node_pools)
   byte_length = 2
-  prefix      = format("%s-", lookup(each.value, "name"))
+  prefix      = "${each.key}-"
   keepers = merge(
     zipmap(
       local.force_node_pool_recreation_resources,