Skip to content

Commit

Permalink
feat: Add support for internal endpoint with ASM module (#1219)
Browse files Browse the repository at this point in the history
* add variable to use internal ip endpoints when running kubectl commands

* update README.md

* generate modules, docs and trailing whitespace

* rename to just internal_ip

Co-authored-by: Yared Mekuria <[email protected]>
  • Loading branch information
f4tal-err0r and Yared Mekuria authored Apr 13, 2022
1 parent 77d08e0 commit 8e87308
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions modules/asm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ To deploy this config:
| enable\_mesh\_feature | Determines whether the module enables the mesh feature on the fleet. | `bool` | `false` | no |
| enable\_vpc\_sc | Determines whether to enable VPC-SC for this ASM installation. For more information read https://cloud.google.com/service-mesh/docs/managed/vpc-sc | `bool` | `false` | no |
| fleet\_id | The fleet to use for this ASM installation. | `string` | `""` | no |
| internal\_ip | Use internal ip for the cluster endpoint when running kubectl commands. | `bool` | `false` | no |
| multicluster\_mode | [Preview] Determines whether remote secrets should be autogenerated across fleet cluster. | `string` | `"manual"` | no |
| project\_id | The project in which the resource belongs. | `string` | n/a | yes |

Expand Down
1 change: 1 addition & 0 deletions modules/asm/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ module "cpr" {
project_id = var.project_id
cluster_name = var.cluster_name
cluster_location = var.cluster_location
internal_ip = var.internal_ip

kubectl_create_command = "${path.module}/scripts/create_cpr.sh ${local.revision_name} ${local.channel} ${var.enable_cni} ${var.enable_vpc_sc}"
kubectl_destroy_command = "${path.module}/scripts/destroy_cpr.sh ${local.revision_name}"
Expand Down
6 changes: 6 additions & 0 deletions modules/asm/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,9 @@ variable "enable_mesh_feature" {
type = bool
default = false
}

variable "internal_ip" {
description = "Use internal ip for the cluster endpoint when running kubectl commands."
type = bool
default = false
}

0 comments on commit 8e87308

Please sign in to comment.