Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/node_pool to include definition of the network ranges #1222

Open
apeabody opened this issue Apr 13, 2022 · 4 comments
Open
Labels
P4 low priority issues triaged Scoped and ready for work

Comments

@apeabody
Copy link
Contributor

apeabody commented Apr 13, 2022

TL;DR

Update examples/node_pool to include definition of the network ranges. For example move

to

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/77d08e02d738c38a5c68987572ef506a987dd41e/examples/node_pool

Expected behavior

No response

Observed behavior

No response

Terraform Configuration

N/A

Terraform Version

N/A

Additional information

No response

@apeabody apeabody added the bug Something isn't working label Apr 13, 2022
@apeabody apeabody self-assigned this Apr 13, 2022
@morgante morgante removed the bug Something isn't working label Apr 13, 2022
@morgante
Copy link
Contributor

@apeabody We really want to reduce the use of variables over-time, actually. Ideally most examples should be self-contained and liberally include static values instead of variables.

@apeabody
Copy link
Contributor Author

@morgante Agreed, this issue is the example isn't totally self-contained as that network range is defined in the test fixture. Thought?

@morgante
Copy link
Contributor

The ideal fix would be moving the network creation from the fixture to the example. Eventually we want to get rid of fixtures entirely.

@apeabody apeabody changed the title examples/node_pool statically defined the pod_range name for pool-03 Update examples/node_pool to include definition of the network ranges Apr 13, 2022
@apeabody
Copy link
Contributor Author

SG - I updated the issue to align.

@apeabody apeabody added P4 low priority issues triaged Scoped and ready for work labels Apr 14, 2022
@apeabody apeabody removed their assignment Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 low priority issues triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants