chore: move network to node_pool examples #1339
Closed
+616
−1,045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting on hold per other priorities. |
|
@apeabody
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/deploy_service/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/deploy_service/README.md
18,20d17
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
23d19
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/disable_client_cert/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/disable_client_cert/README.md
15,17d14
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
21d17
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/safer_cluster_iap_bastion/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/safer_cluster_iap_bastion/README.md
42,44d41
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for pods | `string` | `"ip-range-svc"` | no |
< | network\_name | The name of the network being created to host the cluster in | `string` | `"safer-cluster-network"` | no |
48d44
< | subnet\_name | The name of the subnet being created to host the cluster in | `string` | `"safer-cluster-subnet"` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/shared_vpc/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/shared_vpc/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
19d15
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_beta/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_beta/README.md
19,20d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
22d19
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
29d25
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_with_networking/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_with_networking/README.md
11,13d10
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for services | `string` | `"ip-range-scv"` | no |
< | network | The VPC network created to host the cluster in | `string` | `"gke-network"` | no |
16d12
< | subnetwork | The subnetwork created to host the cluster in | `string` | `"gke-subnet"` | no |
25,26c21,22
< | ip\_range\_pods\_name | The secondary IP range used for pods |
< | ip\_range\_services\_name | The secondary IP range used for services |
---
> | ip\_range\_pods | The secondary IP range used for pods |
> | ip\_range\_services | The secondary IP range used for services |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_zonal_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_zonal_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_zonal_with_asm/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_zonal_with_asm/README.md
11,13d10
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
16d12
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/stub_domains/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/stub_domains/README.md
17,19d16
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
22d18
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/stub_domains_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/stub_domains_private/README.md
19,21d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
24d20
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/workload_identity/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/workload_identity/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for pods | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/deploy_service/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/deploy_service/README.md
18,20d17
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
23d19
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/disable_client_cert/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/disable_client_cert/README.md
15,17d14
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
21d17
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/safer_cluster_iap_bastion/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/safer_cluster_iap_bastion/README.md
42,44d41
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for pods | `string` | `"ip-range-svc"` | no |
< | network\_name | The name of the network being created to host the cluster in | `string` | `"safer-cluster-network"` | no |
48d44
< | subnet\_name | The name of the subnet being created to host the cluster in | `string` | `"safer-cluster-subnet"` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/shared_vpc/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/shared_vpc/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
19d15
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_beta/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_beta/README.md
19,20d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
22d19
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
29d25
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_with_networking/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_with_networking/README.md
11,13d10
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for services | `string` | `"ip-range-scv"` | no |
< | network | The VPC network created to host the cluster in | `string` | `"gke-network"` | no |
16d12
< | subnetwork | The subnetwork created to host the cluster in | `string` | `"gke-subnet"` | no |
25,26c21,22
< | ip\_range\_pods\_name | The secondary IP range used for pods |
< | ip\_range\_services\_name | The secondary IP range used for services |
---
> | ip\_range\_pods | The secondary IP range used for pods |
> | ip\_range\_services | The secondary IP range used for services |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_zonal_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_zonal_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_zonal_with_asm/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_zonal_with_asm/README.md
11,13d10
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
16d12
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/stub_domains/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/stub_domains/README.md
17,19d16
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
22d18
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/stub_domains_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/stub_domains_private/README.md
19,21d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
24d20
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/workload_identity/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/workload_identity/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for pods | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
Running terraform fmt
╷
│
Error:
Attribute redefined
│
│
on examples/simple_regional_with_kubeconfig/main.tf line 37, in module "gke":
│
37:
ip_range_pods
= var.ip_range_pods
│
│
The argument "ip_range_pods" was already set at
│
examples/simple_regional_with_kubeconfig/main.tf:35,3-16. Each argument may
│
be set only once.
╵
╷
│
Error:
Attribute redefined
│
│
on examples/simple_regional_with_kubeconfig/main.tf line 38, in module "gke":
│
38:
ip_range_services
= var.ip_range_services
│
│
The argument "ip_range_services" was already set at
│
examples/simple_regional_with_kubeconfig/main.tf:36,3-20. Each argument may
│
be set only once.
╵
Error: terraform fmt failed with exit code 2
Check the output for diffs and correct using terraform fmt <dir> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1222