Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move network to node_pool examples #1339

Closed
wants to merge 1 commit into from
Closed

chore: move network to node_pool examples #1339

wants to merge 1 commit into from

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Aug 1, 2022

Fixes #1222

@apeabody
Copy link
Contributor Author

Putting on hold per other priorities.

@apeabody apeabody closed this Aug 26, 2022
@comment-bot-dev
Copy link

@apeabody
Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_generate_modules
    The modules need to be regenerated. Please run make_build.
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/deploy_service/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/deploy_service/README.md
18,20d17
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
23d19
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/disable_client_cert/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/disable_client_cert/README.md
15,17d14
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
21d17
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/safer_cluster_iap_bastion/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/safer_cluster_iap_bastion/README.md
42,44d41
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for pods | `string` | `"ip-range-svc"` | no |
< | network\_name | The name of the network being created to host the cluster in | `string` | `"safer-cluster-network"` | no |
48d44
< | subnet\_name | The name of the subnet being created to host the cluster in | `string` | `"safer-cluster-subnet"` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/shared_vpc/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/shared_vpc/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
19d15
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_beta/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_beta/README.md
19,20d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
22d19
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
29d25
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_regional_with_networking/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_regional_with_networking/README.md
11,13d10
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for services | `string` | `"ip-range-scv"` | no |
< | network | The VPC network created to host the cluster in | `string` | `"gke-network"` | no |
16d12
< | subnetwork | The subnetwork created to host the cluster in | `string` | `"gke-subnet"` | no |
25,26c21,22
< | ip\_range\_pods\_name | The secondary IP range used for pods |
< | ip\_range\_services\_name | The secondary IP range used for services |
---
> | ip\_range\_pods | The secondary IP range used for pods |
> | ip\_range\_services | The secondary IP range used for services |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_zonal_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_zonal_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/simple_zonal_with_asm/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/simple_zonal_with_asm/README.md
11,13d10
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
16d12
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/stub_domains/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/stub_domains/README.md
17,19d16
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
22d18
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/stub_domains_private/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/stub_domains_private/README.md
19,21d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
24d20
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/workload_identity/README.md /tmp/tmp.i7tju5J5b6/workspace/examples/workload_identity/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for pods | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
  • ⚠️check_documentation
    The documentation needs to be regenerated. Please run make generate_docs.
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/deploy_service/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/deploy_service/README.md
18,20d17
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
23d19
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/disable_client_cert/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/disable_client_cert/README.md
15,17d14
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
21d17
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/safer_cluster_iap_bastion/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/safer_cluster_iap_bastion/README.md
42,44d41
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for pods | `string` | `"ip-range-svc"` | no |
< | network\_name | The name of the network being created to host the cluster in | `string` | `"safer-cluster-network"` | no |
48d44
< | subnet\_name | The name of the subnet being created to host the cluster in | `string` | `"safer-cluster-subnet"` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/shared_vpc/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/shared_vpc/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
19d15
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_beta/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_beta/README.md
19,20d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
22d19
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
29d25
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_regional_with_networking/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_regional_with_networking/README.md
11,13d10
< | ip\_range\_pods\_name | The secondary ip range to use for pods | `string` | `"ip-range-pods"` | no |
< | ip\_range\_services\_name | The secondary ip range to use for services | `string` | `"ip-range-scv"` | no |
< | network | The VPC network created to host the cluster in | `string` | `"gke-network"` | no |
16d12
< | subnetwork | The subnetwork created to host the cluster in | `string` | `"gke-subnet"` | no |
25,26c21,22
< | ip\_range\_pods\_name | The secondary IP range used for pods |
< | ip\_range\_services\_name | The secondary IP range used for services |
---
> | ip\_range\_pods | The secondary IP range used for pods |
> | ip\_range\_services | The secondary IP range used for services |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_zonal_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_zonal_private/README.md
12,14d11
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
17d13
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/simple_zonal_with_asm/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/simple_zonal_with_asm/README.md
11,13d10
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
16d12
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/stub_domains/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/stub_domains/README.md
17,19d16
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
22d18
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/stub_domains_private/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/stub_domains_private/README.md
19,21d18
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for services | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
24d20
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/examples/workload_identity/README.md /tmp/tmp.QrShHigSeo/generate_docs/workspace/examples/workload_identity/README.md
13,15d12
< | ip\_range\_pods | The secondary ip range to use for pods | `any` | n/a | yes |
< | ip\_range\_services | The secondary ip range to use for pods | `any` | n/a | yes |
< | network | The VPC network to host the cluster in | `any` | n/a | yes |
18d14
< | subnetwork | The subnetwork to host the cluster in | `any` | n/a | yes |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
  • ⚠️check_terraform
    Failed Terraform check. More details below.
Running terraform fmt
╷
│

Error: 
Attribute redefined
│

│

 on examples/simple_regional_with_kubeconfig/main.tf line 37, in module "gke":
│

 37:   
ip_range_pods
         = var.ip_range_pods
│

│

The argument "ip_range_pods" was already set at
│

examples/simple_regional_with_kubeconfig/main.tf:35,3-16. Each argument may
│

be set only once.
╵
╷
│

Error: 
Attribute redefined
│

│

 on examples/simple_regional_with_kubeconfig/main.tf line 38, in module "gke":
│

 38:   
ip_range_services
     = var.ip_range_services
│

│

The argument "ip_range_services" was already set at
│

examples/simple_regional_with_kubeconfig/main.tf:36,3-20. Each argument may
│

be set only once.
╵
Error: terraform fmt failed with exit code 2
Check the output for diffs and correct using terraform fmt <dir>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz Awaiting requested review from ericyz ericyz will be requested when the pull request is marked ready for review ericyz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update examples/node_pool to include definition of the network ranges
2 participants
@apeabody @comment-bot-dev