Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various fix to address CI issues #1248

Merged
merged 1 commit into from
May 12, 2022
Merged

fix: various fix to address CI issues #1248

merged 1 commit into from
May 12, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented May 11, 2022 •
edited
Loading

Fix #1247
Fix #1249
Fix #1245

@apeabody apeabody requested review from a team, Jberlinsky and bharathkkb as code owners May 11, 2022 19:15
@comment-bot-dev
Copy link

comment-bot-dev commented May 11, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody changed the title chore: convert remaining examples/CI to COS_CONTAINERD Various Fixes May 11, 2022
@apeabody apeabody changed the title Various Fixes Various Fix/Chore to address CI May 11, 2022
@apeabody apeabody mentioned this pull request May 11, 2022
Closed
@apeabody apeabody changed the title Various Fix/Chore to address CI fix: various fix to address CI issues May 11, 2022
@apeabody
Copy link
Contributor Author

apeabody commented May 11, 2022 •
edited
Loading

@bharathkkb hopefully this should address the failing tests #1185 (comment)

bharathkkb
bharathkkb approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these @apeabody

examples/node_pool/main.tf Outdated Show resolved Hide resolved
@apeabody
chore: convert remaining examples/CI to COS_CONTAINERD
e206a45 
fix: add output "service_account" to simple_zonal

fix: various fix to address CI issues
@apeabody apeabody merged commit 9e92318 into terraform-google-modules:master May 12, 2022
@apeabody apeabody deleted the chore-COS_CONTAINERD branch May 12, 2022 19:10
@release-please release-please bot mentioned this pull request May 12, 2022
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
fix: various fix to address CI issues (terraform-google-modules#1248)
5a64eea 
fix: add output "service_account" to simple_zonal

chore: convert remaining examples/CI to COS_CONTAINERD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@apeabody @comment-bot-dev @bharathkkb