Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi nic): support enabling multi networking #1721

Conversation

sebastiandero
Copy link

No description provided.

@sebastiandero sebastiandero requested review from Jberlinsky, ericyz and a team as code owners August 25, 2023 08:11
@google-cla
Copy link

google-cla bot commented Aug 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sebastiandero sebastiandero force-pushed the feature/enable-multi-nic branch from 09d34fe to 3595738 Compare August 25, 2023 08:12
feat: support enabling multi networking
@sebastiandero sebastiandero changed the title support enabling multi networking feat(multi nic): support enabling multi networking Aug 25, 2023
@sebastiandero sebastiandero force-pushed the feature/enable-multi-nic branch from 82c49b7 to a518c51 Compare August 25, 2023 08:28
@ericyz
Copy link
Collaborator

ericyz commented Sep 4, 2023

Hi @sebastiandero , thanks for your contribution. Minor note on the PR here. Please refer to this #1722 to update the *.tmpl file and run make build to generate the TF files based on the tmpl files.

Please let me know if you have any questions. Thanks

Copy link

github-actions bot commented Nov 4, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants