Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TPG>=4.81.0)!: add fqdn policies #1729

Merged
merged 6 commits into from
Oct 17, 2023
Merged

feat(TPG>=4.81.0)!: add fqdn policies #1729

merged 6 commits into from
Oct 17, 2023

Conversation

TheKangaroo
Copy link
Contributor

Fixes #1728
Please let me know if anything is missing. This is my first PR to this repo.

@TheKangaroo TheKangaroo requested review from Jberlinsky, ericyz and a team as code owners September 6, 2023 10:21
@google-cla
Copy link

google-cla bot commented Sep 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@TheKangaroo TheKangaroo force-pushed the feat/fqdn-policies branch 2 times, most recently from 0c37cdc to 38430c4 Compare September 18, 2023 14:51
@TheKangaroo
Copy link
Contributor Author

@Jberlinsky @ericyz I fixed a bug in the template and the lint should work now. At least it worked on my local machine.

@ericyz ericyz self-assigned this Sep 20, 2023
@ericyz
Copy link
Collaborator

ericyz commented Sep 20, 2023

Hi @TheKangaroo - thank you for your contribution. I'll review and trigger the CI

@ericyz
Copy link
Collaborator

ericyz commented Sep 20, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Sep 20, 2023

A note for myself. The feature introduced in
https://github.com/hashicorp/terraform-provider-google/releases/tag/v4.81.0

@ericyz ericyz changed the title feat: add fqdn policies feat!: add fqdn policies Sep 20, 2023
@ericyz
Copy link
Collaborator

ericyz commented Sep 21, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Sep 22, 2023

LGTM

@ericyz
Copy link
Collaborator

ericyz commented Sep 22, 2023

/gcbrun

shakeebshams
shakeebshams approved these changes Sep 22, 2023
View reviewed changes
Copy link

@shakeebshams shakeebshams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheKangaroo
Copy link
Contributor Author

I merged the latest changes from master, because of version conflicts. I hope this is ok, I'm not too familiar with the PR process in this repo.

@ericyz
Copy link
Collaborator

ericyz commented Sep 25, 2023

@TheKangaroo - That's all good. Once the Integration test passes, we'll merge

@ericyz
Copy link
Collaborator

ericyz commented Sep 25, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator

ericyz commented Sep 25, 2023

/gcbrun

apeabody
apeabody reviewed Sep 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@apeabody apeabody changed the title feat!: add fqdn policies feat(TPG>=4.81.0)!: add fqdn policies Sep 27, 2023
@apeabody
Copy link
Contributor

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator

ericyz commented Sep 28, 2023

/gcbrun

@TheKangaroo
Copy link
Contributor Author

Is there anything I need to fix to make the pipeline succeed? I think I cannot see the pipeline output.

@apeabody
Copy link
Contributor

Is there anything I need to fix to make the pipeline succeed? I think I cannot see the pipeline output.

I re-triggered it as the failure didn't appear related to the code change.

@TheKangaroo
Copy link
Contributor Author

Hi, I don't want to bother you but is there anything I can do to get the PR merged soon? We have 'manually' enabled the feature on some clusters and now we can't update the provider until we can set the option via the module.

@apeabody
Copy link
Contributor

apeabody commented Oct 9, 2023

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Oct 9, 2023

Hi, I don't want to bother you but is there anything I can do to get the PR merged soon? We have 'manually' enabled the feature on some clusters and now we can't update the provider until we can set the option via the module.

Trigger a fresh run of the CI

apeabody
apeabody previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @TheKangaroo!

autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Contributor

/gcbrun

@TheKangaroo
Copy link
Contributor Author

@Jberlinsky @apeabody Can we continue with this PR?

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody dismissed their stale review October 17, 2023 15:47

Pending CI Tests

@apeabody
Copy link
Contributor

Thanks for the contribution @TheKangaroo!

@apeabody apeabody merged commit 2beb720 into terraform-google-modules:master Oct 17, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Oct 17, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@TheKangaroo
feat(TPG>=4.81.0)!: add fqdn policies (terraform-google-modules#1729)
dfcc6af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz ericyz approved these changes

@shakeebshams shakeebshams shakeebshams approved these changes

@apeabody apeabody apeabody left review comments

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees

@ericyz ericyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuration of FQDN Network Policies on gke cluster
4 participants
@TheKangaroo @ericyz @apeabody @shakeebshams