Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: uses random_string for test setup #1732

Merged
merged 3 commits into from
Sep 12, 2023
Merged

chore: uses random_string for test setup #1732

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43bb51b
chore: uses random_string for test
apeabody Sep 11, 2023
327f67d
Merge branch 'master' into apeabody-patch-3
apeabody Sep 11, 2023
b235115
Merge branch 'master' into apeabody-patch-3
apeabody Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/setup/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,12 @@ module "gke-project-1" {
source = "terraform-google-modules/project-factory/google"
version = "~> 14.0"

name = "ci-gke-${random_id.random_project_id_suffix.hex}"
random_project_id = true
org_id = var.org_id
folder_id = var.folder_id
billing_account = var.billing_account
name = "ci-gke-${random_id.random_project_id_suffix.hex}"
random_project_id = true
random_project_id_length = 4
org_id = var.org_id
folder_id = var.folder_id
billing_account = var.billing_account
# due to https://github.com/hashicorp/terraform-provider-google/issues/9505 for AP
default_service_account = "keep"

Expand Down