Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project and location output to fleet-membership #1740

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat: add project and location output to fleet-membership #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e011d18
feat: add project and location output to fleet-membership
apeabody Sep 18, 2023
129bca2
gen docs
apeabody Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/fleet-membership/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ To deploy this config:
| Name | Description |
|------|-------------|
| cluster\_membership\_id | The ID of the hub membership |
| location | The location of the hub membership. |
| project\_id | The project of the hub membership. |
| wait | An output to use when you want to depend on registration finishing |

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
13 changes: 12 additions & 1 deletion modules/fleet-membership/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright 2022 Google LLC
* Copyright 2022-2023 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,3 +23,14 @@ output "wait" {
description = "An output to use when you want to depend on registration finishing"
value = var.enable_fleet_registration ? google_gke_hub_membership.primary[0].membership_id : local.gke_hub_membership_name
}

output "project_id" {
apeabody marked this conversation as resolved.
Show resolved Hide resolved
description = "The project of the hub membership."
value = local.hub_project_id
}

output "location" {
# TODO: google_gke_hub_membership b/300473592
description = "The location of the hub membership."
value = "global"
}