Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support confidential nodepools #1756

Conversation

abhikaddy
Copy link
Contributor

@abhikaddy abhikaddy commented Oct 1, 2023

This fixes open issue #1386.

@abhikaddy abhikaddy requested review from Jberlinsky, ericyz and a team as code owners October 1, 2023 13:15
@google-cla
Copy link

google-cla bot commented Oct 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@abhikaddy abhikaddy changed the title Fix support confidential nodepools fix: support confidential nodepools Oct 1, 2023
@abhikaddy abhikaddy changed the title fix: support confidential nodepools feat: support confidential nodepools Oct 1, 2023
@abhikaddy
Copy link
Contributor Author

@apeabody Good Day! can I get a review?

@apeabody
Copy link
Collaborator

apeabody commented Oct 9, 2023

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Oct 9, 2023

@apeabody Good Day! can I get a review?

Triggered the Integration tests

@abhikaddy
Copy link
Contributor Author

@apeabody can I get access to build failure logs?

@apeabody
Copy link
Collaborator

/gcbrun

@abhikaddy
Copy link
Contributor Author

Hi Good Day!
Can I get a merge? @apeabody @Jberlinsky @ericyz

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 24, 2023
@github-actions github-actions bot closed this Dec 31, 2023
@apeabody apeabody reopened this Aug 26, 2024
@apeabody apeabody requested a review from gtsorbo as a code owner August 26, 2024 21:03
@github-actions github-actions bot removed the Stale label Aug 26, 2024
@t-indumathy
Copy link
Contributor

Can you also backport this change to v30.x pls, as this is a gap that ought to have been addressed from that version?

@apeabody
Copy link
Collaborator

Thanks for the contribution @abhikaddy!

Can you please rebase your change? Thanks!

@t-indumathy
Copy link
Contributor

@abhikaddy Can you please rebase ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants