-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for configuring allow_net_admin in autopilot clusters #1768
feat: Add support for configuring allow_net_admin in autopilot clusters #1768
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Is anyone still working on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contibution @rossbannerman!
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - After updating the template you will need to re-run make generate
and make generate_docs
.
@apeabody How's that? Thanks again for the guidance - appreciate it |
/gcbrun |
Thanks - Triggered the CI |
/gcbrun |
Re-triggering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @rossbannerman!
Makes
allow_net_admin
configurable in new and existing clusters. Defaults tofalse
. Commonly required by service meshes such as Istio and LinkerdFeedback appreciated!
Changes:
autogen/main/cluster.tf.tmpl
autogen/main/variables.tf.tmpl
Documentation: