Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for configuring allow_net_admin in autopilot clusters #1768

Merged
merged 11 commits into from
Nov 15, 2023

Conversation

rossbannerman
Copy link
Contributor

@rossbannerman rossbannerman commented Oct 11, 2023

Makes allow_net_admin configurable in new and existing clusters. Defaults to false. Commonly required by service meshes such as Istio and Linkerd

Feedback appreciated!

Changes:

  • autogen/main/cluster.tf.tmpl
  • autogen/main/variables.tf.tmpl

Documentation:

@rossbannerman rossbannerman requested review from Jberlinsky, ericyz and a team as code owners October 11, 2023 22:22
@google-cla
Copy link

google-cla bot commented Oct 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sonja-hiltunen-ivadolabs

Is anyone still working on this?

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contibution @rossbannerman!

autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - After updating the template you will need to re-run make generate and make generate_docs.

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
cluster.tf Outdated Show resolved Hide resolved
@rossbannerman
Copy link
Contributor Author

@apeabody How's that? Thanks again for the guidance - appreciate it

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

@apeabody How's that? Thanks again for the guidance - appreciate it

Thanks - Triggered the CI

@rossbannerman
Copy link
Contributor Author

@apeabody How's that? Thanks again for the guidance - appreciate it

Thanks - Triggered the CI

Thanks! Looks like this failed but I can't seem to see the results 👀

@apeabody
Copy link
Contributor

@apeabody How's that? Thanks again for the guidance - appreciate it

Thanks - Triggered the CI

Thanks! Looks like this failed but I can't seem to see the results 👀

At least initially appears to be unrelated, I've opened #1801

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Re-triggering Error: Error waiting for creating GKE cluster: Failed to create cluster

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rossbannerman!

@apeabody apeabody merged commit 493149d into terraform-google-modules:master Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants