Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pod_range in private cluster #1803

Conversation

shubhamkr619
Copy link
Contributor

@shubhamkr619 shubhamkr619 commented Nov 17, 2023

Trying to support the ticket id #1802. The ticket required to have pod_range to deploy node_pools to a different range from the cluster.

Adding extra support for placement group as well. These features are available in private-cluster-beta and now supported in GA

@ericyz
Copy link
Collaborator

ericyz commented Nov 19, 2023

Thank you for the contribution. Please update the template in the autogen folder and run make build to generate the change to other modules

@shubhamkr619 shubhamkr619 force-pushed the feature/private_network_config branch from c1a7af8 to a7832ff Compare November 20, 2023 06:10
@shubhamkr619 shubhamkr619 force-pushed the feature/private_network_config branch from 86286a0 to 434c3a7 Compare November 20, 2023 06:26
…619/terraform-google-kubernetes-engine into feature/private_network_config
@shubhamkr619
Copy link
Contributor Author

@ericyz , please check now.

@ericyz
Copy link
Collaborator

ericyz commented Nov 20, 2023

/gcbrun

@ericyz ericyz changed the title add support for pod_range in private cluster feat: add support for pod_range in private cluster Nov 20, 2023
@ericyz
Copy link
Collaborator

ericyz commented Nov 20, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Nov 21, 2023

diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/cluster.tf /tmp/tmp.T3mqCaeXrt/workspace/modules/private-cluster/cluster.tf
457a458,472

dynamic "placement_policy" {
for_each = length(lookup(each.value, "placement_policy", "")) > 0 ? [each.value] : []
content {
type = lookup(placement_policy.value, "placement_policy", null)
}
}

dynamic "network_config" {
for_each = length(lookup(each.value, "pod_range", "")) > 0 ? [each.value] : []
content {
pod_range = lookup(network_config.value, "pod_range", null)
enable_private_nodes = var.enable_private_nodes
}
}

Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

@shubhamkr619
Copy link
Contributor Author

@ericyz , pls review this, for some reason reruning the make build generated extra changes.

@ericyz
Copy link
Collaborator

ericyz commented Nov 22, 2023

/gcbrun

@shubhamkr619
Copy link
Contributor Author

@eric can we merge this, one of the customer is waiting for this

@ericyz ericyz merged commit 9c62f1f into terraform-google-modules:master Nov 22, 2023
4 checks passed
@fabmaiad
Copy link

Thank you for your contribution, this PR helped me a lot.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants