Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds local_nvme_ssd_block_config to beta-public-cluster #1912

Merged
merged 24 commits into from
Apr 12, 2024
Merged

feat: adds local_nvme_ssd_block_config to beta-public-cluster #1912

merged 24 commits into from
Apr 12, 2024

Conversation

florianMalbranque
Copy link
Contributor

No description provided.

matilote and others added 13 commits July 4, 2023 19:08
@matilote
Update cluster.tf
3fcef77
@matilote
add local nvme block in autogen templates instead
ba93f63
@matilote
update modules with make build
9896a4c
@matilote
Merge branch 'terraform-google-modules:master' into master
7cdf727
@matilote
Merge branch 'master' into master
0ce5e0e
@apeabody @florianMalbranque
feat: add direct fleet registration option (terraform-google-modules#…
0c0382c 
…1878)
@release-please @florianMalbranque
chore(master): release 30.1.0 (terraform-google-modules#1865)
2a0bd9e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@apeabody @florianMalbranque
feat: add cross project fleet service agent (terraform-google-modules…
f3f4bf5 
…#1896)
@release-please @florianMalbranque
chore(master): release 30.2.0 (terraform-google-modules#1897)
153d23f 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@cloud-pharaoh @florianMalbranque
fix: make master_ipv4_cidr_block optional for autopilot (terraform-go…
7bef577 
…ogle-modules#1902)
@renovate @florianMalbranque
chore(deps): Update go modules and/or dev-tools (terraform-google-mod…
c52a5ab 
…ules#1889)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @florianMalbranque
chore(deps): Update nginx Docker tag to v1.25.4 (terraform-google-mod…
90d4a3a 
…ules#1877)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@florianMalbranque
Merge branch 'terraform-google-modules:master' into master
d74c232
@florianMalbranque florianMalbranque requested review from ericyz, gtsorbo and a team as code owners March 23, 2024 09:26
@google-cla Google CLA
Copy link

google-cla bot commented Mar 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@florianMalbranque
Copy link
Contributor Author

@gtsorbo , @ericyz , @Jberlinsky would you please take a look ?

@apeabody
Copy link
Contributor

/gcbrun

@florianMalbranque
Copy link
Contributor Author

@apeabody, would you be able to trigger CI again and give your approval please ?

@apeabody
Copy link
Contributor

apeabody commented Apr 3, 2024 •
edited
Loading

/gcbrun

(re-trigger, quota)

@florianMalbranque
Copy link
Contributor Author

had to rebase again,
@apeabody would you be able to trigger ci run again please ?

@gtsorbo , @ericyz , @Jberlinsky <ould you be able to approve please ?

@apeabody
Copy link
Contributor

apeabody commented Apr 4, 2024

/gcbrun

apeabody
apeabody requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @florianMalbranque!

I've included a few notes below.

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/README.md Show resolved Hide resolved
autogen/main/README.md Outdated Show resolved Hide resolved
@florianMalbranque
Copy link
Contributor Author

Thanks for your review @apeabody, it should be good now

@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

Hi @florianMalbranque - Looks like we need a quick make build, thanks!

@florianMalbranque
Copy link
Contributor Author

Woops 🤦 , @apeabody make build executed and committed ✔️

@apeabody
Copy link
Contributor

apeabody commented Apr 8, 2024

/gcbrun

apeabody
apeabody requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @florianMalbranque - A few final notes on the if beta_cluster blocks as ephemeral_storage_config is still beta.

autogen/main/README.md Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
@florianMalbranque
Copy link
Contributor Author

Thanks again for your reviews @apeabody ! it should be good now, PTAL

@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @florianMalbranque!

@apeabody apeabody merged commit f7c2ed9 into terraform-google-modules:master Apr 12, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Apr 12, 2024
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@florianMalbranque @matilote @cloud-pharaoh
feat: adds local_nvme_ssd_block_config to beta-public-cluster (terraf…
4a1c824 
…orm-google-modules#1912)

Co-authored-by: Mateusz Jędrzejewski <[email protected]>
Co-authored-by: Mateusz Jędrzejewski <[email protected]>
Co-authored-by: Amina Mansour <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

@gtsorbo gtsorbo Awaiting requested review from gtsorbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florianMalbranque @apeabody @matilote @cloud-pharaoh