-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SR-2692: Support enabling workload identity during hub registration #997
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I'll sign the CLA as soon as legal gives me the green light |
Thanks for the PR! 🚀 |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This might be superseded by #947. |
Ok, I can close this for now and continue using our fork of the hub module until this is ready. |
In order to be able to install Anthos Service Mesh 1.9 or higher, it now requires an identity provider to be set:
https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/blob/1.9.8-asm.1+config1/scripts/asm-installer/install_asm#L2157
The solution for that is to pass the
--enable-workload-identity
flag when registering with the hub (instead of SA key).Adding a new variable
enable_workload_identity
to thehub
module that will pass this flag when registering.Tested happy path in our terraform project by pulling in this module through our forked repo.