Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR-2692: Support enabling workload identity during hub registration #997

Closed
wants to merge 2 commits into from

Conversation

gtrog
Copy link

@gtrog gtrog commented Sep 8, 2021

In order to be able to install Anthos Service Mesh 1.9 or higher, it now requires an identity provider to be set:
https://github.com/GoogleCloudPlatform/anthos-service-mesh-packages/blob/1.9.8-asm.1+config1/scripts/asm-installer/install_asm#L2157

The solution for that is to pass the --enable-workload-identity flag when registering with the hub (instead of SA key).

Adding a new variable enable_workload_identity to the hub module that will pass this flag when registering.

Tested happy path in our terraform project by pulling in this module through our forked repo.

@gtrog gtrog requested review from bharathkkb, Jberlinsky and a team as code owners September 8, 2021 13:36
@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gtrog
Copy link
Author

gtrog commented Sep 8, 2021

I'll sign the CLA as soon as legal gives me the green light

@comment-bot-dev
Copy link

comment-bot-dev commented Sep 8, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@morgante
Copy link
Contributor

morgante commented Sep 8, 2021

This might be superseded by #947.

@gtrog
Copy link
Author

gtrog commented Sep 8, 2021

This might be superseded by #947.

Ok, I can close this for now and continue using our fork of the hub module until this is ready.

@gtrog gtrog closed this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants