feat: add a submodule to support proxy based regional external load balancer #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
g-awmalik
changed the title
|
@jeffling-google - PTAL at the int test failure. Seems like you're using a network that's already in use. |
…ted by other examples
|
Changing the network name of the example/regional_proxy_lb to avoid conflicting with the network names in other example(s). |
|
/gcbrun |
|
@imrannayer - can you take a look at this? |
imrannayer
reviewed
Oct 18, 2023
imrannayer
reviewed
Oct 18, 2023
imrannayer
reviewed
Oct 18, 2023
imrannayer
reviewed
Oct 18, 2023
imrannayer
reviewed
Oct 18, 2023
|
@jeffling-google We are not using old tetsing framework. Can you plz create tests using new framework? |
…rm-google-modules#72) Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
… for the old test framework
imrannayer
reviewed
Nov 13, 2023
imrannayer
reviewed
Nov 13, 2023
|
/gcbrun |
…f, enable compute API
|
/gcbrun |
imrannayer
reviewed
Nov 14, 2023
…framework is used
|
/gcbrun |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ted by other examples
… for the old test framework
…f, enable compute API
…framework is used
…-google/terraform-google-lb into feature/regional-ext-lb Rebase to remote repo.
|
/gcbrun |
|
Fixed in #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature request is documented in b/303348819