feat: adding cmek settings in log bucket #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imrannayer Can you please trigger the pipeline ? |
imrannayer
reviewed
Nov 9, 2023
modules/logbucket/main.tf
Outdated
| @@ -40,6 +40,9 @@ resource "google_logging_project_bucket_config" "bucket" { | |||
| enable_analytics = var.enable_analytics | |||
| bucket_id = var.name | |||
| locked = var.locked | |||
| cmek_settings { | |||
There was a problem hiding this comment.
@Saloni-Patidar This code will be optional and should execute when keys are provided. Check storage module how to handle it?
There was a problem hiding this comment.
@imrannayer should we add a new folder with these settings as an option?
There was a problem hiding this comment.
@Saloni-Patidar no need for a separate folder. Just add conditional execution of this block so it will only execute when cmek keys are provided.
|
@imrannayer can you check this now? |
|
/gcbrun |
|
/gcbrun |
|
@imrannayer how can we solve this error? |
|
/gcbrun |
|
@imrannayer are we good to merge this? |
imrannayer
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding cmek_settings in log bucket.