fix: Add variables type as first parameter on all variables (#167)

* Add variables type as first parameter on all variables

* update README

modules/fabric-net-svpc-access/README.md

@@ -41,13 +41,13 @@ module "net-shared-vpc-access" {
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | host\_project\_id | Project id of the shared VPC host project. | string | n/a | yes |
-| host\_service\_agent\_role | Assign host service agent role to users in host_service_agent_users variable. | string | `"false"` | no |
-| host\_service\_agent\_users | List of IAM-style users that will be granted the host service agent role on the host project. | list | `<list>` | no |
-| host\_subnet\_regions | List of subnet regions, one per subnet. | list | `<list>` | no |
-| host\_subnet\_users | Map of comma-delimited IAM-style members to which network user roles for subnets will be assigned. | map | `<map>` | no |
-| host\_subnets | List of subnet names on which to grant network user role. | list | `<list>` | no |
+| host\_service\_agent\_role | Assign host service agent role to users in host_service_agent_users variable. | bool | `"false"` | no |
+| host\_service\_agent\_users | List of IAM-style users that will be granted the host service agent role on the host project. | list(string) | `<list>` | no |
+| host\_subnet\_regions | List of subnet regions, one per subnet. | list(string) | `<list>` | no |
+| host\_subnet\_users | Map of comma-delimited IAM-style members to which network user roles for subnets will be assigned. | map(any) | `<map>` | no |
+| host\_subnets | List of subnet names on which to grant network user role. | list(string) | `<list>` | no |
 | service\_project\_ids | Ids of the service projects that will be attached to the Shared VPC. | list(string) | n/a | yes |
-| service\_project\_num | Number of service projects that will be attached to the Shared VPC. | string | `"0"` | no |
+| service\_project\_num | Number of service projects that will be attached to the Shared VPC. | number | `"0"` | no |
 
 ## Outputs
 

modules/fabric-net-svpc-access/variables.tf

@@ -15,42 +15,49 @@
  */
 
 variable "host_project_id" {
+  type        = string
   description = "Project id of the shared VPC host project."
 }
 
 # passed-in values can be dynamic, so variables used in count need to be separate
 
 variable "service_project_num" {
+  type        = number
   description = "Number of service projects that will be attached to the Shared VPC."
   default     = 0
 }
 
 variable "service_project_ids" {
-  description = "Ids of the service projects that will be attached to the Shared VPC."
   type        = list(string)
+  description = "Ids of the service projects that will be attached to the Shared VPC."
 }
 
 variable "host_subnets" {
+  type        = list(string)
   description = "List of subnet names on which to grant network user role."
   default     = []
 }
 
 variable "host_subnet_regions" {
+  type        = list(string)
   description = "List of subnet regions, one per subnet."
   default     = []
 }
 
 variable "host_subnet_users" {
+  type        = map(any)
   description = "Map of comma-delimited IAM-style members to which network user roles for subnets will be assigned."
   default     = {}
 }
 
 variable "host_service_agent_role" {
+  type        = bool
   description = "Assign host service agent role to users in host_service_agent_users variable."
   default     = false
 }
 
 variable "host_service_agent_users" {
+  type        = list(string)
   description = "List of IAM-style users that will be granted the host service agent role on the host project."
   default     = []
 }