Skip to content

Commit

Permalink
feat: allow to specify project_region and namespace for private-servi…
Browse files Browse the repository at this point in the history
…ce-connect
  • Loading branch information
sanadhis committed Feb 28, 2024
1 parent 592577f commit 67ca7ca
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
2 changes: 2 additions & 0 deletions modules/private-service-connect/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ If you have a firewall rule blocking egress traffic, you will need to configure
| private\_service\_connect\_ip | The internal IP to be used for the private service connect. | `string` | n/a | yes |
| private\_service\_connect\_name | Private Service Connect endpoint name. Defaults to `global-psconnect-ip` | `string` | `"global-psconnect-ip"` | no |
| project\_id | Project ID for Private Service Connect. | `string` | n/a | yes |
| service\_directory\_namespace | Service Directory namespace to register the forwarding rule under. | `string` | `null` | no |
| service\_directory\_region | Service Directory region to register this global forwarding rule under. Defaults to `us-central1` if not defined. | `string` | `null` | no |

## Outputs

Expand Down
9 changes: 9 additions & 0 deletions modules/private-service-connect/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,13 @@ resource "google_compute_global_forwarding_rule" "forwarding_rule_private_servic
network = var.network_self_link
ip_address = google_compute_global_address.private_service_connect.id
load_balancing_scheme = ""

dynamic "service_directory_registrations" {
for_each = var.service_directory_namespace != null || var.service_directory_region != null ? [1] : []

content {
namespace = var.service_directory_namespace
service_directory_region = var.service_directory_region
}
}
}
12 changes: 12 additions & 0 deletions modules/private-service-connect/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,15 @@ variable "forwarding_rule_target" {
error_message = "For forwarding_rule_target only `all-apis` and `vpc-sc` are valid."
}
}

variable "service_directory_namespace" {
description = "Service Directory namespace to register the forwarding rule under."
type = string
default = null
}

variable "service_directory_region" {
description = "Service Directory region to register this global forwarding rule under. Defaults to `us-central1` if not defined."
type = string
default = null
}

0 comments on commit 67ca7ca

Please sign in to comment.