Skip to content

Commit

Permalink
updated test
Browse files Browse the repository at this point in the history
  • Loading branch information
imrannayer committed Oct 2, 2024
1 parent 3a6c8fb commit be402bf
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
1 change: 0 additions & 1 deletion examples/hierarchical-firewall-policy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ This example creates a Service Account and 2 hierarchical firewall policy. First
| folder1 | The folder\_id ID 1 to to create firewall policy in | `any` | n/a | yes |
| folder2 | The folder\_id ID 2 to attach firewal policy to | `any` | n/a | yes |
| folder3 | The folder\_id ID 3 to attach firewal policy to | `any` | n/a | yes |
| org\_id | The org ID attach firewal policy to | `any` | n/a | yes |
| project\_id | The project ID to host the network in | `any` | n/a | yes |

## Outputs
Expand Down
1 change: 0 additions & 1 deletion examples/hierarchical-firewall-policy/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ module "firewal_policy" {
parent_node = "folders/${var.folder1}"
policy_name = "${local.prefix}-firewall-policy-${random_string.random_suffix.result}"
description = "test ${local.prefix} firewall policy"
target_org = var.org_id
target_folders = [var.folder2, var.folder3]

rules = [
Expand Down
4 changes: 0 additions & 4 deletions examples/hierarchical-firewall-policy/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ variable "folder2" {
variable "folder3" {
description = "The folder_id ID 3 to attach firewal policy to"
}

variable "org_id" {
description = "The org ID attach firewal policy to"
}
3 changes: 2 additions & 1 deletion test/setup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,14 @@ resource "google_folder" "folder3" {

module "project" {
source = "terraform-google-modules/project-factory/google"
version = "~> 15.0"
version = "~> 17.0"

name = "ci-network"
random_project_id = "true"
org_id = var.org_id
folder_id = google_folder.folder2.id
billing_account = var.billing_account
deletion_policy = "DELETE"

activate_apis = [
"cloudresourcemanager.googleapis.com",
Expand Down

0 comments on commit be402bf

Please sign in to comment.