-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/103 submodules #116
Merged
morgante
merged 39 commits into
terraform-google-modules:release/2.0
from
taylorludwig:feature/103-submodules
Dec 6, 2019
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dedcf4c
fix makefile
taylorludwig 0a135c0
move vpc creation to its own module
taylorludwig 987b4e4
move subnets to own module
taylorludwig 28a26a2
move routes to its own submodule
taylorludwig 211a516
use for_each for route creation
taylorludwig 2dd1fad
update developer tools version to fix generate doc errors
taylorludwig 6e0faef
generate docs
taylorludwig 2c8ed09
add readme to submodules
taylorludwig f566110
formatting fix
taylorludwig f3e5e99
changelog
taylorludwig 605269a
lock provider for google_project_services removal error
taylorludwig 3a3a408
specify provider versions for each module for terraform init/validate
taylorludwig fec8285
Revert "specify provider versions for each module for terraform init/…
taylorludwig 560bbb2
required provider versions on modules
taylorludwig fc02b37
Update CHANGELOG.md
taylorludwig 188bf1c
remove compatability from submodules
taylorludwig 2831941
update variable descriptions
taylorludwig 8649e43
switch routes back to list type with map generated within module
taylorludwig d567d89
default rotue values to null so google_compute_route defaults are used
taylorludwig b5b9ad8
update output names per pr
taylorludwig e95a6b7
switch shared_vpc_host to bool
taylorludwig a351412
simpler way to return project id for shared vpc
taylorludwig 4146283
update changelog and readme for list structure
taylorludwig c9a6090
fix terraform fmt issues
taylorludwig db0448e
name isn't required anymore
taylorludwig 84119a8
default output needs to be to match original value so tests and back…
taylorludwig babfafa
fix readme examples
taylorludwig 6b10555
remove unused leftover var
taylorludwig f0443f7
remove network var for route depedency. Its inherit by passing in net…
taylorludwig f86ad43
remove description
taylorludwig 2f6aee7
rename svpc_project_id to project_id
taylorludwig 6e7ffd1
use a module_depends_on list instead of using explicit subnet
taylorludwig da5372d
lint/validate fixes
taylorludwig 7ec22d8
initial migrate.py from gke module
taylorludwig 99a3819
update migrate.py to work with google-network resources and for_each …
taylorludwig 69615da
remove old sh migrate script
taylorludwig 2d4027a
update readme for new py migrate script
taylorludwig 3afde82
python format
taylorludwig 9342a26
update migration doc to mention issue with single count mvs
taylorludwig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,7 @@ | |
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,7 @@ | |
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* Copyright 2019 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* Copyright 2019 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* Copyright 2019 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,7 @@ | |
terraform { | ||
required_version = "~> 0.12.0" | ||
} | ||
|
||
provider "google" { | ||
version = "~> 2.18.0" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a required version constraint, not a direct module invocation.