Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add in disabled field to firewall-rules #524

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

NA2047
Copy link
Contributor

@NA2047 NA2047 commented Dec 3, 2023

This is currently not in the module, just adding it so users can enable and disable fw rules as needed. This will not break existing user configurations

@NA2047 NA2047 requested review from imrannayer and a team as code owners December 3, 2023 01:06
Copy link

google-cla bot commented Dec 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NA2047 NA2047 changed the title Add the ability to disable and enable firewall rules feat: Add in disabled field to firewall-rules Dec 3, 2023
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit f851f06 into terraform-google-modules:master Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants