Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: src_threat_intelligences is missing from the variable object definition. #530

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

joaquinza
Copy link
Contributor

src_threat_intelligences is missing from the variable object definition.

src_threat_intelligences is missing from the variable object definition.
@joaquinza joaquinza requested review from imrannayer and a team as code owners December 14, 2023 07:22
Copy link

google-cla bot commented Dec 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joaquinza joaquinza changed the title Update variables.tf bug: src_threat_intelligences is missing from the variable object definition. Dec 15, 2023
@imrannayer imrannayer added the waiting-response Waiting for issue author to respond. label Dec 15, 2023
@imrannayer
Copy link
Collaborator

@joaquinza thx for the PR. CLA needs to be signed first.

Thanks

@joaquinza
Copy link
Contributor Author

@joaquinza thx for the PR. CLA needs to be signed first.

Thanks

I tried signing it (and when I click on the links, it looks like signed) But for some reason it does not show like signed in the checks. Also I noticed that the check has not re-triggered since the original trigger.

@imrannayer
Copy link
Collaborator

/gcbrun

@joaquinza
Copy link
Contributor Author

I added the readme modified by make generate_docs but the lint seems to be waiting on something.

@imrannayer imrannayer removed the waiting-response Waiting for issue author to respond. label Dec 22, 2023
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title bug: src_threat_intelligences is missing from the variable object definition. fix: src_threat_intelligences is missing from the variable object definition. Dec 25, 2023
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit 654c366 into terraform-google-modules:master Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants