feat: Add new submodule for service networking #569
Conversation
q2w
force-pushed
the
feature/service_networking
branch
from
582a8ca to
303862d
Compare
q2w
force-pushed
the
feature/service_networking
branch
3 times, most recently
from
3eca387 to
7000a7c
Compare
q2w
force-pushed
the
feature/service_networking
branch
from
7000a7c to
b3d6203
Compare
q2w
force-pushed
the
feature/service_networking
branch
2 times, most recently
from
675b9b8 to
7990fae
Compare
| for_each = { for address in var.global_addresses : address.name => address } | ||
| project = var.project_id | ||
| name = each.value.name | ||
| purpose = each.value.purpose |
There was a problem hiding this comment.
IIUC for this private service access usecase isn't it always VPC_PEERING?
There was a problem hiding this comment.
I have used VPC_PEERING as default value. Should i remove the variable and use VPC_PEERING directly?
There was a problem hiding this comment.
@q2w In case of service networking it will always be vpc_peering.
modules/service-networking/README.md
Outdated
| @@ -0,0 +1,28 @@ | |||
| # Terraform Google service networking | |||
|
|
|||
| This module creates global network address and a service networking | |||
There was a problem hiding this comment.
Could we add some more context on the uses cases? IIUC this module would be used for private service access. Is there any other usecase cc @imrannayer
There was a problem hiding this comment.
Updated the module README and example README
q2w
force-pushed
the
feature/service_networking
branch
from
c3b896f to
015be39
Compare
|
/gcbrun |
|
@q2w @bharathkkb how are we going to handle this sub-module and current sub-module? They both are same. Although Current module has a flaw that it accepts one IP address instead of list of ip addresses. |
@imrannayer Thanks for pointing to the current module! Before creating this PR i tried to check if some module exist which can create service networking. I missed finding out private_service_access sub-module. IMHO the current submodule can fulfill the requirements. In future we can update the current module to take multiple addresses. I would defer to @bharathkkb for final call on the current PR. |
|
Good catch @imrannayer, yes let's close this and update current module as Imran pointed out. Sorry for the churn @q2w! |
This PR makes below changes,