New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create module and example for NCC #575

Merged

imrannayer merged 10 commits into terraform-google-modules:master from gleichda:ncc-module

Sep 30, 2024

Contributor

gleichda commented Aug 27, 2024

No description provided.

gleichda requested review from imrannayer and a team as code owners

August 27, 2024 13:52


          feat: Create module and example for NCC

b32dd66

gleichda force-pushed the ncc-module branch from 01d071f to b32dd66 Compare

August 27, 2024 13:53

gleichda changed the title ~~Create module and example for NCC~~ feat: Create module and example for NCC

imrannayer self-assigned this

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/versions.tf Outdated Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/versions.tf Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

test/fixtures/network_connectivity_center/main.tf Outdated Show resolved Hide resolved

Collaborator

imrannayer commented Aug 28, 2024

@gleichda thanks for the PR. Left a few comments. Can you also add the test in integration test

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/main.tf Outdated Show resolved Hide resolved


          Implement findings from Review

51db90a

gleichda requested a review from imrannayer

September 23, 2024 12:15


          Merge branch 'master' into ncc-module

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

Collaborator

imrannayer commented Sep 23, 2024 •

edited

Loading

/gcbrun

Collaborator

imrannayer commented Sep 23, 2024

@gleichda integration test is failing. Can u plz add role roles/networkconnectivity.hubAdmin in IAM file?

gleichda added 2 commits

September 24, 2024 06:21


          Remove default text for description and add NCC Hub Admin for test setup

bf9a6b6


          Merge branch 'ncc-module' of github.com:gleichda/terraform-google-net…

3d9a8f4

…work into ncc-module

gleichda requested a review from imrannayer

September 24, 2024 06:23

imrannayer reviewed

View reviewed changes

modules/network-connectivity-center/variables.tf Outdated Show resolved Hide resolved

imrannayer self-requested a review

September 24, 2024 11:54

Collaborator

imrannayer commented Sep 24, 2024

/gcbrun


          Change default for empty string to null instead and regenerate docs

df17a73


          Allowing the test SA to also create GCE instances

27c1e6a

Collaborator

imrannayer commented Sep 24, 2024

/gcbrun


          Fix permadiff in output

2a7c753

Collaborator

imrannayer commented Sep 26, 2024

/gcbrun


          Add include export ranges to ncc module

6dd5626

Collaborator

imrannayer commented Sep 27, 2024

/gcbrun

1 similar comment

Collaborator

imrannayer commented Sep 27, 2024

/gcbrun


          Add artificial dependency to overcome internal error until the underl…

3e2a92f

…ying bug is fixed

Collaborator

imrannayer commented Sep 30, 2024

/gcbrun

imrannayer approved these changes

View reviewed changes

imrannayer merged commit 3a6c8fb into terraform-google-modules:master

4 checks passed

release-please bot mentioned this pull request

chore(master): release 9.3.0 #578

Merged

gleichda deleted the ncc-module branch

October 1, 2024 13:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet