Release v2.0 #86

morgante · 2019-10-24T21:01:57Z

Release branch for v2.0. Incorporates:

Blocked by:

Working migration script, potentially blocked by When I change count to for_each, the resource will rebuild ? hashicorp/terraform#22375
Fixes Network 2.0 #103
Fixes Create Consolidated output #77
Fixes Updating any subnet in a list causes subsequent subnets to be re-created #70
Fixes var.subnets count inconsistent with data.google_compute_subnetwork.created_subnets #100
Fixes FR: Ability to set Sample Rate of subnet flow logs #125
Passing tests
Manual testing by two people: @morgante and TBD

I also updated the outputs as well. This will be large state change however and probably needs to be a major release

I also added some debug output to tests to make tracking this down in the future a bit easier

Whoops, missed these

This reverts commit 1dd8c4e.

This warning was being thrown by the linter ``` Checking file headers 1 files have incorrect boilerplate headers: test/integration/secondary_ranges/controls/inspec_attributes.rb ```

Making sure `depends_on = [google_compute_subnetwork.subnetwork]` is correctly added in after a rebase as per #81

This reverts commit aee0cc0.

The migrate script will now migrate all the modules

fix: updated subnets to use for_each rather then count

…ards compatability don't break

…work name

johnroach · 2019-11-26T21:43:46Z

Hi @morgante and @tfhartmann , please do ping me if there is any way I can help to get this branch released. I would really like this resolved.

tfhartmann · 2019-11-26T21:45:02Z

Hi @morgante and @tfhartmann , please do ping me if there is any way I can help to get this branch released. I would really like this resolved.

@morgante I'll echo what @johnroach said. Please do let me know if there is something I could do. I'd also like to see this resolved.

…migration

Feature/103 submodules

…asefix 2.0 release upgrade guide

morgante · 2019-12-09T18:02:27Z

@tfhartmann Sorry for the long delay on this, but finally released!

tfhartmann and others added 26 commits October 11, 2019 11:44

fix: updated subnets to use for_each rather then count

8a79411

I also updated the outputs as well. This will be large state change however and probably needs to be a major release

fix: fixing incorrect outputs

f1590db

wip: tried chaging to list, didnt' work. Going to do more debugging

f2839e8

fix: fixed outputs so they would match the outputs of splat

1392cf0

I also added some debug output to tests to make tracking this down in the future a bit easier

fix: formatting! From hells heart I curse thee!

264b2e0

fix: cleaned up example outputs declarations

71939d2

feat: adding some tests to validate outputs

b17126e

fix: doh, don't comment out the tests

188b777

feat: and low. I have created tests for outputs

17e12e5

fix: removing spurious comments

e89d26b

Whoops, missed these

fix: removed outputs from the firewall example

a57883c

Revert "fix: removed outputs from the firewall example"

7c43cf0

This reverts commit 1dd8c4e.

docs: fixing header warning

d451d32

This warning was being thrown by the linter ``` Checking file headers 1 files have incorrect boilerplate headers: test/integration/secondary_ranges/controls/inspec_attributes.rb ```

fix: ran make docker_generate_docs

ff274e9

wip: adding tests for outputs in the firewall submodule

a440fce

fix: syntax update to make the for loop more readable

c19fd95

docs: WIP on migration docs

f886fd7

feat: added migrations docs and a migration script

4233054

lint: Fixing docs and linting errors

a1d5d04

wip: updated migration script to run migration commands

0e771c9

rebase: add back depends_on for subnets after a rebase

aee0cc0

Making sure `depends_on = [google_compute_subnetwork.subnetwork]` is correctly added in after a rebase as per #81

Revert "rebase: add back depends_on for subnets after a rebase"

14f3be3

This reverts commit aee0cc0.

moved migrate.sh into the helpers dir

f3bebfc

feat: made the scipt work across multiple modules

1c99d28

The migrate script will now migrate all the modules

Merge branch 'master' into tfhartmann-issue70

45d31ce

Merge pull request #73 from tfhartmann/tfhartmann-issue70

6880832

fix: updated subnets to use for_each rather then count

morgante requested review from andreyk-code and Jeanno as code owners October 24, 2019 21:01

morgante requested a review from a team October 24, 2019 21:01

morgante requested a review from a team as a code owner October 24, 2019 21:01

taylorludwig added 10 commits November 25, 2019 16:52

fix terraform fmt issues

c9a6090

name isn't required anymore

db0448e

default output needs to be to match original value so tests and backw…

84119a8

…ards compatability don't break

fix readme examples

babfafa

remove unused leftover var

6b10555

remove network var for route depedency. Its inherit by passing in net…

f0443f7

…work name

remove description

f86ad43

rename svpc_project_id to project_id

2f6aee7

use a module_depends_on list instead of using explicit subnet

6e7ffd1

lint/validate fixes

da5372d

taylorludwig added 5 commits November 27, 2019 10:19

initial migrate.py from gke module

7ec22d8

update migrate.py to work with google-network resources and for_each …

99a3819

…migration

remove old sh migrate script

69615da

update readme for new py migrate script

2d4027a

python format

3afde82

aaron-lane mentioned this pull request Dec 2, 2019

var.subnets count inconsistent with data.google_compute_subnetwork.created_subnets #100

Closed

taylorludwig and others added 6 commits December 2, 2019 10:47

update migration doc to mention issue with single count mvs

9342a26

Merge pull request #116 from taylorludwig/feature/103-submodules

b60f0ab

Feature/103 submodules

Merge branch 'master' into release/2.0

1b63ed9

Remove unused locals from main.tf

ecdfe25

Slightly rework upgrade guide

1a0602d

Small bugfixes to upgrade script

b51a1e5

morgante closed this Dec 7, 2019

morgante reopened this Dec 7, 2019

morgante added 2 commits December 6, 2019 19:09

Fix dryrun command in docs

f4a98d1

Merge pull request #127 from terraform-google-modules/bugfix/2.0-rele…

a172ad3

…asefix 2.0 release upgrade guide

morgante merged commit f599bed into master Dec 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.0 #86

Release v2.0 #86

morgante commented Oct 24, 2019 •

edited

Loading

johnroach commented Nov 26, 2019

tfhartmann commented Nov 26, 2019

morgante commented Dec 9, 2019

Release v2.0 #86

Release v2.0 #86

Conversation

morgante commented Oct 24, 2019 • edited Loading

johnroach commented Nov 26, 2019

tfhartmann commented Nov 26, 2019

morgante commented Dec 9, 2019

morgante commented Oct 24, 2019 •

edited

Loading